-
Notifications
You must be signed in to change notification settings - Fork 624
Update OP Superchain chains #9629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Nov 2, 2025
LukaszRozmej
added a commit
that referenced
this pull request
Nov 3, 2025
* Reduce peer logging (#9591) * Cancel timeout in NewPayload fast-path (#9597) * Refactor JsonRpcService.ExecuteAsync (#9600) * Refactor JsonRpcService.ExecuteAsync * Feedback * Add reflection cache * Optimize DeserializeParameters * Optimize enumeration * Can be made static * Remove unused using * Use regular Dictionary * formatting * Optimise CREATE(2) remove redundant account creation (#9585) * delay creation of executor account * store nonce zero for new executor * remove account creation --------- Co-authored-by: Marc Harvey-Hill <[email protected]> * Replace Task.Delay/Thread.Sleep with NUnit .After() in tests (#9576) * Initial plan * Convert Task.Delay and Thread.Sleep to After pattern in tests Co-authored-by: LukaszRozmej <[email protected]> * Fix async method signatures after removing await Co-authored-by: LukaszRozmej <[email protected]> * Add NSubstituteExtensions and refactor to use ReceivedBool helper Co-authored-by: LukaszRozmej <[email protected]> * fix * Try avoiding exceptions * increase Timeout * change * fix * whitespace * make Big_test Explicit * fix negative paths * revert one test * Revert inappropriate After() conversions for blocking tests Co-authored-by: asdacap <[email protected]> * Remove redundant diagnostic messages from ReceivedCallsMatching Co-authored-by: flcl42 <[email protected]> * Display diagnostic message only once per test when ReceivedCallsMatching fails Co-authored-by: LukaszRozmej <[email protected]> * Remove diagnostic logging from ReceivedCallsMatching to avoid issues Co-authored-by: LukaszRozmej <[email protected]> * remove stale annotation --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> Co-authored-by: lukasz.rozmej <[email protected]> Co-authored-by: asdacap <[email protected]> Co-authored-by: flcl42 <[email protected]> * Arbitrum - Refund on contract creation failure (#9610) * extension for arbitrum on refund at contract deployment failure * Fix eth_sumulate defaults (#9529) * Fix * Refactor * Test * Fix taiko * Revert "Test" This reverts commit 9eb30e0. * Fix * Fix gas * Test * Fix validate flag * Fix taiko * Fix gasEstimation tests * Add more flags * Fix tests * Change flags * Try fix tests * Fix tests * Proper nonce validation * More fixes * Revert * Fix tests * Fix types * Add two tests * Fix known-failing-tests * Default type * known failing tests * Fix suggestions * Fix tests * Extra peers reporting for supported chains runs (#9612) * Fix StatelessExecution tool build (#9613) * Fix/pow forward header provider cache ownership (#9614) * Fix: return copy from cache to avoid use-after-dispose * add a test * Update EthereumTests (#9225) * Update tests to fix missing test jsons * Use newer tests; add more moern legacy tests; fix transition tests; fix slnx * Rename projects; remove Blockchain tests as it was moved to legacy fully * Fix a csproj * Add tests * Add tests * Move transaition tests to legacy too; simplify namespaces * Fix workflow * Fix syntax * Fix transaction tests * Add empty coinbase * Add coinbase even if transaction is declined * Fix evm slnx compilation * Can be failing cause? * Return blockhash tests * Rollback coinbase set for blockchain tests * Less tests as old one have broken format * Rm TODO, as SuicideStorage tests are covered by state tests * Fix * Update to 5.0.0 * Remove redundant length==1 special-case in SliceWithZeroPadding (#9566) * Catch index exceptions in RlpDecoders and pack it in RlpException (#9603) * Catch index exceptions in RlpDecoders and pack it in RlpException * Catch index exceptions in RlpDecoders and pack it in RlpException (#9604) * Initial plan * Update RLP decoders to inherit from base classes with exception handling Updated all RLP decoder classes to inherit from RlpValueDecoder<T> or RlpStreamDecoder<T> instead of directly implementing interfaces. This ensures all decoders automatically get IndexOutOfRangeException and ArgumentOutOfRangeException handling, wrapping them in RlpException. Changed decoders: - WithdrawalDecoder, KeccakDecoder, LogEntryDecoder - AuthorizationTupleDecoder, AccessListDecoder - AccountDecoder, HeaderDecoder, BlockDecoder, BlockBodyDecoder - ChainLevelDecoder, BlockInfoDecoder - ReceiptMessageDecoder, ReceiptStorageDecoder, CompactReceiptStorageDecoder - ReceiptArrayStorageDecoder All decode methods renamed to DecodeInternal and marked as protected override. All Encode/GetLength methods marked as override where needed. Co-authored-by: LukaszRozmej <[email protected]> * Update remaining RLP decoders across all modules Updated RLP decoders in Consensus.Clique, Network, Consensus.AuRa, Taiko, and Xdc modules to inherit from base classes: - Consensus.Clique: SnapshotDecoder - Network: NetworkNodeDecoder - Consensus.AuRa: ValidatorInfoDecoder, PendingValidatorsDecoder - Taiko: L1OriginDecoder - Xdc: ExtraConsensusDataDecoder, QuorumCertificateDecoder, SnapshotDecoder, TimeoutCertificateDecoder, TimeoutDecoder, VoteDecoder, XdcBlockInfoDecoder All decoders now inherit from RlpValueDecoder<T> or RlpStreamDecoder<T> to get automatic exception handling for IndexOutOfRangeException and ArgumentOutOfRangeException. Co-authored-by: LukaszRozmej <[email protected]> * Mark all RLP decoder classes as sealed Added sealed modifier to all 27 RLP decoder classes to prevent further inheritance: - Core decoders (15): WithdrawalDecoder, KeccakDecoder, LogEntryDecoder, AccountDecoder, HeaderDecoder, BlockDecoder, BlockBodyDecoder, ChainLevelDecoder, BlockInfoDecoder, ReceiptMessageDecoder, ReceiptStorageDecoder, CompactReceiptStorageDecoder, ReceiptArrayStorageDecoder, AuthorizationTupleDecoder, AccessListDecoder - Consensus decoders (3): SnapshotDecoder (Clique), ValidatorInfoDecoder (AuRa), PendingValidatorsDecoder (AuRa) - Network decoder (1): NetworkNodeDecoder - Taiko decoder (1): L1OriginDecoder - Xdc decoders (7): ExtraConsensusDataDecoder, QuorumCertificateDecoder, SnapshotDecoder, TimeoutCertificateDecoder, TimeoutDecoder, VoteDecoder, XdcBlockInfoDecoder These classes are not inherited from and marking them as sealed provides better performance and clearer design intent. Co-authored-by: LukaszRozmej <[email protected]> * Update remaining RLP decoders: BasicStreamDecoder, TxDecoder, and OptimismReceiptMessageDecoder Updated the last remaining decoder implementations to inherit from base classes: - BasicStreamDecoder.cs: Updated 6 primitive type decoders (ByteStreamDecoder, ShortStreamDecoder, UShortStreamDecoder, IntStreamDecoder, UIntStreamDecoder, ULongStreamDecoder) to inherit from RlpStreamDecoder<T> and marked as sealed - TxDecoder.cs: Updated TxDecoder<T> base class to inherit from RlpValueDecoder<T> (not sealed as it has subclasses: TxDecoder, SystemTxDecoder, GeneratedTxDecoder) - OptimismReceiptMessageDecoder.cs: Updated OptimismReceiptMessageDecoder to inherit from RlpStreamDecoder<TxReceipt> (not sealed as it has subclass OptimismReceiptTrieDecoder) All decoders now have automatic exception handling for IndexOutOfRangeException and ArgumentOutOfRangeException. Co-authored-by: LukaszRozmej <[email protected]> * Fix TxDecoder: Add back Rlp Encode method for test compatibility Added the `Rlp Encode(T item, RlpBehaviors)` method that was removed during refactoring. This method is used by tests and provides a convenient way to encode transactions to Rlp without manually creating a RlpStream. The method internally uses the override Encode method to ensure exception handling is still applied. Co-authored-by: LukaszRozmej <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> * fix build --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> * Add more logging in MultiSyncModeSelector (#9616) * Add more logging * fix for seq * feat: Add configurable EIP-2935 ring buffer size (#9611) * Blockchain Engine Tests support (#9394) * initial commit * fix normal blockchain tests * tidy * restore disposes * comment out BALs * fix var declaration * don't set basefeepergas if null * use network from genesis in blockchain test * update blockchain test base * add tracer to blockchain tests runner * tidy * tidy * add genesis processing timeout * check for null head block * try undo some changes * detect failure to process genesis * check removal is error * add back checks for genesis spec * only add noenginerequeststracker in tests * comment sealed block check * try remove timeout * only configure merge for engine tests * fix merge module init * add back timeout and remove sealer * await new payloads * use reflection for engine rpc method calling --------- Co-authored-by: Marc Harvey-Hill <[email protected]> * use zero address when from address not specified in rpc calls (#9578) * use zero address for null values * small test * fix proof rpc * fix test and add more changes * Allow serving snap requests for more than 128 blocks (#9602) * Initial plan * Add SnapServingMaxDepth configuration and update LastNStateRootTracker Co-authored-by: tanishqjasoria <[email protected]> * Add clarifying comments for configuration changes Co-authored-by: tanishqjasoria <[email protected]> * Get reorgDepth from config instead of hardcoding in test Co-authored-by: LukaszRozmej <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: tanishqjasoria <[email protected]> Co-authored-by: Tanishq Jasoria <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> * Remove console log from FileTestsSource (#9622) Removed console log for loading test file. * Correct docs value for Blocks.BlockProductionMaxTxKilobytes (#9620) * Update OP Superchain chains (#9629) Co-authored-by: emlautarom1 <[email protected]> * Auto-update fast sync settings (#9628) Co-authored-by: rubo <[email protected]> * feat: write AckMessage directly to IByteBuffer without temp array (#9623) * Optimize Ripemd (#9627) --------- Co-authored-by: Ben {chmark} Adams <[email protected]> Co-authored-by: Marc <[email protected]> Co-authored-by: Marc Harvey-Hill <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> Co-authored-by: asdacap <[email protected]> Co-authored-by: flcl42 <[email protected]> Co-authored-by: Stavros Vlachakis <[email protected]> Co-authored-by: Nikita Mescheryakov <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: radik878 <[email protected]> Co-authored-by: Alexey Osipov <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: Daniil Ankushin <[email protected]> Co-authored-by: Tanishq Jasoria <[email protected]> Co-authored-by: tanishqjasoria <[email protected]> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <[email protected]> Co-authored-by: VolodymyrBg <[email protected]>
kamilchodola
added a commit
that referenced
this pull request
Nov 9, 2025
* Add more logging in MultiSyncModeSelector (#9616) * Add more logging * fix for seq * feat: Add configurable EIP-2935 ring buffer size (#9611) * Blockchain Engine Tests support (#9394) * initial commit * fix normal blockchain tests * tidy * restore disposes * comment out BALs * fix var declaration * don't set basefeepergas if null * use network from genesis in blockchain test * update blockchain test base * add tracer to blockchain tests runner * tidy * tidy * add genesis processing timeout * check for null head block * try undo some changes * detect failure to process genesis * check removal is error * add back checks for genesis spec * only add noenginerequeststracker in tests * comment sealed block check * try remove timeout * only configure merge for engine tests * fix merge module init * add back timeout and remove sealer * await new payloads * use reflection for engine rpc method calling --------- Co-authored-by: Marc Harvey-Hill <[email protected]> * use zero address when from address not specified in rpc calls (#9578) * use zero address for null values * small test * fix proof rpc * fix test and add more changes * Allow serving snap requests for more than 128 blocks (#9602) * Initial plan * Add SnapServingMaxDepth configuration and update LastNStateRootTracker Co-authored-by: tanishqjasoria <[email protected]> * Add clarifying comments for configuration changes Co-authored-by: tanishqjasoria <[email protected]> * Get reorgDepth from config instead of hardcoding in test Co-authored-by: LukaszRozmej <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: tanishqjasoria <[email protected]> Co-authored-by: Tanishq Jasoria <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> * Remove console log from FileTestsSource (#9622) Removed console log for loading test file. * Correct docs value for Blocks.BlockProductionMaxTxKilobytes (#9620) * Update OP Superchain chains (#9629) Co-authored-by: emlautarom1 <[email protected]> * Auto-update fast sync settings (#9628) Co-authored-by: rubo <[email protected]> * feat: write AckMessage directly to IByteBuffer without temp array (#9623) * Optimize Ripemd (#9627) * Allow precompile cache to be switched off by config (#9633) * Mainnet Osaka, BPO1, BPO2 forks (#9615) * Change rlp limits and add logs (#9631) * log rlp guard messages * Adding stack trace * Increase receipts limit to 1024 * fix for stack trace * try fix multiline * fix * whitespace * try fix * More logs and potential fixes * log fix * Revert "More logs and potential fixes"This reverts commit ec71c87.# Conflicts:# src/Nethermind/Nethermind.Network/MessageSerializationService.csRevert "log fix"This reverts commit b3b1f5f. Revert "More logs and potential fixes" This reverts commit ec71c87. * try weird fix * Revert "try weird fix" This reverts commit 0bdfb3d. * revert packages.json * simplify log * Don't abbreviate ForkchoiceStateV1 hashes * revert spammy ForkchoiceStateV1 * Fix missed dispose on StorageRange in ProgressTracker * fix test * Optimise CALL by throwing stack underflow earlier (#9581) * fail fast * add unit tests --------- Co-authored-by: Marc Harvey-Hill <[email protected]> * Optimize BN254Pairing call (#9621) * Optimize BN254Pairing call * Don't modify input * Skip locals * Tweak inlining * Update src/Nethermind/Nethermind.Evm.Precompiles/BN254.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Less fixed * Optimize * Optimize * formatting * formatting * Tidy * Use constants * Feedback * Skip init * Faster * More skip init * Make mul ReadOnlySpan, add comments * Simplify * Skip locals * Ruben making me work for it * More working for it * Still working for it * Update benchmarks * Apply suggestions from code review Co-authored-by: Marc <[email protected]> * Feedback --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Marc <[email protected]> * Update OP Superchain chains (#9643) Co-authored-by: LukaszRozmej <[email protected]> * Log/decrease noise (#9642) * decrease Ethash cache miss log * Decrease block downloader invalid bloc log * Update X handle (#9634) * Better logs on invalid orphan (#9641) * Try fixing world wrong block * not this, so keep validating Withdrawals * Update all op chain configs (#9645) * update configs * update all configs * Add `NetworkId` flag to `InitConfig` (#9476) * add flag with networkId * cosmetic * Update src/Nethermind/Nethermind.Api/IInitConfig.cs Co-authored-by: Ruben Buniatyan <[email protected]> * fix * # Conflicts: # src/Nethermind/Nethermind.Api/IInitConfig.cs # src/Nethermind/Nethermind.Api/InitConfig.cs * Revert "# Conflicts:" This reverts commit 7f25638. * postmerge fix * Apply suggestion from @benaadams --------- Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ben {chmark} Adams <[email protected]> * Revert "HACK: enable in fusaka" This reverts commit 7cfad14. * HACK: enable in pectra --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Daniil Ankushin <[email protected]> Co-authored-by: Marc <[email protected]> Co-authored-by: Marc Harvey-Hill <[email protected]> Co-authored-by: Tanishq Jasoria <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: tanishqjasoria <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> Co-authored-by: Ben {chmark} Adams <[email protected]> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <[email protected]> Co-authored-by: rubo <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated Chainspec and config files