postgresql_beta: init at version 16beta3 #249030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: For integration and testing purposes, especially for downstream
consumers (Flakes, etc) that rely on testing against various PostgreSQL
versions, it's useful to have a beta version around. An example of this
is PostgREST, which has several people using Nix in order to test the
server against different versions. Testing against beta versions is
currently awkward because there's no way to get them besides patching
and forking Nixpkgs.
There's a related problem here, which is that the APIs needed to create
your *own* postgresql package, with all extensions, are not exposed.
That might be worth doing later on; but for now, it's easy to just track
beta versions and nip the issue in the bud from there.
The intent is that this `beta` package follows the same basic rules as
the Linux prerelease "beta" packages; that is:
- `postgresql_beta` *always* tracks a beta, even if the corresponding
release is out.
- That means that once PostgreSQL 16 is released, this expression
will be out of date until PostgreSQL 17 Beta 1 is released.
- `postgresql_beta` is updated on a provisional basis i.e. it won't
necessarily get prompt updates or security updates like the other
expressions.
- It is primarily intended for advanced users to test and integrate
against, so they might submit issues to various upstream maintainers.
Many thanks to Laurence Isla, who initially made this change as part of
an effort to integrate PostgREST against PostgreSQL 16 Beta 2.
See also: PostgREST/postgrest#2865
Co-authored-by: Laurence Isla <[email protected]>
Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
commented
Aug 14, 2023
| @@ -98,7 +98,7 @@ let | |||
| ++ lib.optionals jitSupport [ "--with-llvm" ]; | |||
|
|
|||
| patches = [ | |||
| ./patches/disable-resolve_symlinks.patch | |||
| (if atLeast "16" then ./patches/disable-normalize_exec_path.patch else ./patches/disable-resolve_symlinks.patch) | |||
There was a problem hiding this comment.
Note that this line is not moved/the order for patches isn't changed, to avoid spurious rebuilds on other versions. If it's less readable I'm fine with changing it, though.
ofborg
bot
added
11.by: package-maintainer
|
PostgreSQL 16 was released today! https://www.postgresql.org/about/news/postgresql-16-released-2715/ Guess we can just update the hashes/version and then it should be good to merge? |
|
pg 16 was already added on: #255446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For integration and testing purposes, especially for downstream consumers (Flakes, etc) that rely on testing against various PostgreSQL versions, it's useful to have a beta version around. An example of this is PostgREST, which has several people using Nix in order to test the server against different versions. Testing against beta versions is currently awkward because there's no way to get them besides patching and forking Nixpkgs.
There's a related problem here, which is that the APIs needed to create your own postgresql package, with all extensions, are not exposed. That might be worth doing later on; but for now, it's easy to just track beta versions and nip the issue in the bud from there.
The intent is that this
betapackage follows the same basic rules as the Linux prerelease "beta" packages; that is:postgresql_betaalways tracks a beta, even if the corresponding release is out.postgresql_betais updated on a provisional basis i.e. it won't necessarily get prompt updates or security updates like the other expressions.Many thanks to Laurence Isla, who initially made this change as part of an effort to integrate PostgREST against PostgreSQL 16 Beta 2.
See also: PostgREST/postgrest#2865
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)