-
Notifications
You must be signed in to change notification settings - Fork 68
[All Hosts] (formatting) consistently format element names as bold #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Docs Build status updates of commit 1612e0b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
docs/manifest/runtime.md
Outdated
| | Element | Required | Description | | ||
| |:-----|:-----|:-----| | ||
| | [Override](override.md) | No | **Outlook**: Specifies the URL location of the JavaScript file that Outlook Desktop requires for [LaunchEvent extension point](extensionpoint.md#launchevent) handlers. **Important**: At present, you can only define one `<Override>` element and it must be of type `javascript`.| | ||
| | [Override](override.md) | No | **Outlook**: Specifies the URL location of the JavaScript file that Outlook Desktop requires for [LaunchEvent extension point](extensionpoint.md#launchevent) handlers. **Important**: At present, you can only define one **Override** element and it must be of type `javascript`.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this Style Guide page, I see:

It makes me think that we should retain the angle brackets and add bold around them:
| | [Override](override.md) | No | **Outlook**: Specifies the URL location of the JavaScript file that Outlook Desktop requires for [LaunchEvent extension point](extensionpoint.md#launchevent) handlers. **Important**: At present, you can only define one **Override** element and it must be of type `javascript`.| | |
| | [Override](override.md) | No | **Outlook**: Specifies the URL location of the JavaScript file that Outlook Desktop requires for [LaunchEvent extension point](extensionpoint.md#launchevent) handlers. **Important**: At present, you can only define one **<Override>** element and it must be of type `javascript`.| |
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. OK. I'll redo both PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry :(
Thanks for doing this! It's so tedious.
|
Docs Build status updates of commit deb9461: ✅ Validation status: passed
docs/manifest/runtimes.md
docs/manifest/versionoverrides.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 59d0176: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. docs/manifest/action.md
docs/manifest/allformfactors.md
docs/manifest/allowsnapshot.md
docs/manifest/appdomain.md
docs/manifest/appdomains.md
docs/manifest/control.md
docs/manifest/control-button.md
docs/manifest/control-menu.md
This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit a2d79bf: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 65fd02a: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 92f9b2e: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit e74daac: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There is a similar PR for the conceptual docs repo.
I have not changed the file dates, because this seems like a classic case where that would be misleading.