[tools] (YML) Expand type aliases to include links #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJerabek
requested review from
alison-mk,
samantharamon and
ElizabethSamuel-MSFT
alison-mk
approved these changes
Apr 10, 2025
samantharamon
approved these changes
Apr 11, 2025
ElizabethSamuel-MSFT
approved these changes
Apr 21, 2025
|
Learn Build status updates of commit 5bc8ad5: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long PR to address #2245. Unfortunately, it touches every yaml file due to updates to js-yaml and how we're making small edits to the output of api-documenter.
The end result is adding a line to the type alias remarks with links to the included types. Here's what that looks like:
This is a big PR that's not feasible to review line by line. Instead, please look at pages in your feature area. Check enums, type aliases, interfaces, and classes.
Here is the staging link: https://review.learn.microsoft.com/en-us/javascript/api/excel/excel.cardlayout?view=excel-js-preview&branch=AlexJ-TypeDefExpansion