Skip to content

[All Hosts] (auth) specify location of WebApplicationInfo element #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

Rick-Kirkham
Copy link
Contributor

Fixes 2273

Copy link
Contributor

Learn Build status updates of commit de1353f:

✅ Validation status: passed

File Status Preview URL Details
docs/manifest/webapplicationinfo.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider updating to latest style guidance

@@ -23,7 +23,7 @@ The following table applies only to version 1.0 of **\<VersionOverrides\>** elem

## Example

The following is a simple example. For more complex examples, see the manifests for the sample add-ins in [Office Add-in code samples](https://github.com/OfficeDev/Office-Add-in-samples).
The following is a simple example. For more complex examples, see the manifests for the sample add-ins in [Office Add-in code samples](https://github.com/OfficeDev/Office-Add-in-samples). The **\<WebApplicationInfo\>** element must always be the last child of **\<VersionOverrides\>**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following is a simple example. For more complex examples, see the manifests for the sample add-ins in [Office Add-in code samples](https://github.com/OfficeDev/Office-Add-in-samples). The **\<WebApplicationInfo\>** element must always be the last child of **\<VersionOverrides\>**.
The following is a simple example. For more complex examples, see the manifests for the sample add-ins in [Office Add-in code samples](https://github.com/OfficeDev/Office-Add-in-samples). The `\<WebApplicationInfo\>` element must always be the last child of `\<VersionOverrides\>`.

Copy link
Contributor

Learn Build status updates of commit 6d2e6e2:

✅ Validation status: passed

File Status Preview URL Details
docs/manifest/versionoverrides-1-0-content.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/manifest/webapplicationinfo.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)

For more details, please refer to the build report.

For any questions, please:

@Rick-Kirkham Rick-Kirkham merged commit 3bf5581 into main May 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants