Assert zip adapters return values #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests did not properly tests that both adapters had the exact same behavior for returned values. By using common code for testing we can assert that the behavior is now in fact identical. Also phpdocs were moved to the interface itself instead of each adapters.
|
Fixed the code style, that should be mergeable now. |
|
@PowerKiKi Good job. I merge it :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests did not properly tests that both adapters had the exact
same behavior for returned values. By using common code for testing
we can assert that the behavior is now in fact identical.
Also phpdocs were moved to the interface itself instead of each
adapters.