Chapter07 - enhance min-heap implementation #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made two changes to the current implementation of min-heap:
.arrange()method) and deletion(in.sink()method) we can stop iterating as soon as we find out that there is no need to swap the values.delete_at_location()method, we need to compare the newly inserted node with its parent. Here is an example that reveals the bug:After the deletion the output is
[0, 1, 10, 2, 11, 4, 3]which is wrong. If we draw this min-heap we could see that index 5(which has the value of 4) is less smaller than index 2(which has the value of 10)Thanks.