Skip to content

Actionabilize errors from incorrect settings files #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 29, 2019
Merged

Actionabilize errors from incorrect settings files #1263

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f8f8083
Annotatively research current state of exception handling surrounding…
travisclagrone Jun 18, 2019
b75dced
Throw a contextful terminating error if processing the argument of 'I…
travisclagrone Jun 18, 2019
6648344
Refine id and category of error for when processing value of `Invoke-…
travisclagrone Jun 18, 2019
0472359
Revert "Annotatively research current state of exception handling sur…
travisclagrone Jun 18, 2019
a012dec
Do not attempt id and category inference for the error to throw when …
travisclagrone Jun 18, 2019
88ab1ec
Remove `using System.IO`
travisclagrone Jun 23, 2019
2faab31
Revert "Remove `using System.IO`"
travisclagrone Jun 23, 2019
7bb07d5
Remove unused using after refactoring. Use more descriptive variable …
bergmeister Jun 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Engine/Commands/InvokeScriptAnalyzerCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,13 @@ protected override void BeginProcessing()
? rulePaths
: rulePaths.Concat(settingsCustomRulePath).ToArray();
}
catch
catch (Exception exception)
{
this.WriteWarning(String.Format(CultureInfo.CurrentCulture, Strings.SettingsNotParsable));
stopProcessing = true;
return;
this.ThrowTerminatingError(new ErrorRecord(
exception,
"SETTINGS_ERROR",
ErrorCategory.InvalidData,
this.settings));
}

ScriptAnalyzer.Instance.Initialize(
Expand Down Expand Up @@ -357,7 +359,7 @@ protected override void ProcessRecord()
{
ProcessPath();
}

#if !PSV3
// TODO Support dependency resolution for analyzing script definitions
if (saveDscDependency)
Expand Down