-
Notifications
You must be signed in to change notification settings - Fork 404
Add UseUsingScopeModifierInNewRunspaces rule #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bergmeister
merged 59 commits into
PowerShell:master
from
Jawz84:1410_foreach_parallel_rule
Mar 24, 2020
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
8b9f115
Add tests for AvoidUnInitializedVarsInNewRunspaces
0ab5fbf
Add strings for AvoidUnInitializedVarsInNewRunspaces
7182edb
Add documentation
068b1fc
wrestling with Ast in C# - not working
adbeff0
Add sensible warning message
23183d2
remove unnecessary boilerplate from test
83394d6
clean up and finetune rule
99c2bea
Add RuleToTest parameter to Test-ScriptAnalyzer to aid with test driv…
91e6689
increment rule count to fix test
337ac20
add reference to rule documentation
406d7ec
exclude built-in variables
55b7316
change using directive => scoope modifier
ef4b79a
add tests for InlineScript, Invoke-Command and Start-(Thread)Job
36bb1fc
add rule implementation for InlineScript, Invoke-Command and Start-(T…
e7fd6cc
Refactor and cleanup
59ba18b
small cleanup
f64c81c
explain all applicable situations in documentation
db80c8f
simplify code for adding sessions to dict
d1f8df8
Revert "Add RuleToTest parameter to Test-ScriptAnalyzer to aid with t…
c53b65d
Rename rule to UseUsingScopeModifierInNewRunspaces
15bd608
refactor grouping of script blocks by session name
37a5cb1
Add suggested correction implementation
6024c50
Add test for suggested corrections, fix typos
b12d16f
Refactor to AstVisitor/AstVisitor2 WIP
9bc2195
Update Rules/UseUsingScopeModifierInNewRunspaces.cs
Jawz84 f8fa89a
Update Rules/UseUsingScopeModifierInNewRunspaces.cs
Jawz84 6ff3405
Process review comments
889b03a
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parall…
6758748
Add tests for command name and icm -session
e5e6a58
Add icm -session logic to visitor and tidy up
921c1d2
fix build for windows powershell
f57c610
Revert "fix build for windows powershell"
7956eda
Change private class to internal class for Windows PowerShell
427461a
Add logic to detect DSCScriptResource
4f8bf36
Add tests for DSC Script resource
0cb8f9e
Enhance label test topic
Jawz84 af2ceee
repair test indentation and add newline at eof
52bece8
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parall…
29176a8
Move testcases to BeforeAll blocks
b1bee39
Add documentation that DSC Script resource is supported
f6de07d
change string[] to IReadOnlyList<string>
Jawz84 5f6bae0
extract scriptBlockPosition as a variable for readability
Jawz84 bcaba83
put arguments on their own line for readability
1d6b55e
make visitor class a private, nested class in rule
92f19c9
change 'var' to type name for method calls
7943625
fix indentation for nested visitor class
a6acfd7
Remove explicit 'ToList()' for performance
Jawz84 cee3ab7
add check for strongly typed assignments
fe68244
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parall…
c4c4fde
Add todo comments
490d8d9
refactor FindAll predicates to static methods
6767a58
Refactor GetSessionName for performance.
c824fd7
use full type for string expression variable
Jawz84 ab64ebf
use full type name for foreach variable initialization
Jawz84 d5b77a9
refactor diagnostic message out to local variable
Jawz84 6c0e90a
WIP: apply review suggestions
fa7c065
apply review suggestions
378fb16
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parall…
c1247c0
Fix CR/LF -> LF
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add RuleToTest parameter to Test-ScriptAnalyzer to aid with test driv…
…en rule development
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.