Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PyMySQL/mysqlclient
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1fa31fd
Choose a base ref
...
head repository: PyMySQL/mysqlclient
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9fd238b
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Feb 8, 2024

  1. Support ssl=True (#700) 

    MySQL use ssl by default but MariaDB don't.

Until mysqlclient<=2.2.1, `ssl=True` unintentionally allowed and it
called `mysql_ssl_set(mysql, NULL, NULL, NULL, NULL, NULL)`. Although it
is no-op in MySQL Connector, MariaDB Connector silently set
MYSQL_OPT_SSL_ENFORCE when the API is called. (See #698)

In case of PyMySQL, ssl is not used by default but `ssl=True` behave
like `sslmode="PREFERRED"`.

For better backward compatibility and compatibility with PyMySQL and
security, I decided to allow ssl=True and it means sslmode="REQUIRED" on
MySQL Connector and
set MYSQL_OPT_SSL_ENFORCE on MariaDB Connector.

Fix #699
    @methane
    methane authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a7e3887 View commit details
    Browse the repository at this point in the history

  2. release 2.2.4 (#701)

    @methane
    methane authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9fd238b View commit details
    Browse the repository at this point in the history
Loading