super basic watchman support#32
Merged
Merged
Conversation
mmerickel
force-pushed
the
watchman
branch
3 times, most recently
from
d54928c to
d594506
Compare
mmerickel
added a commit
to mmerickel/hupper
that referenced
this pull request
May 21, 2018
digitalresistor
approved these changes
May 21, 2018
Member
Author
|
When using this on a real project I ran into some corner cases that I need to try and handle. Can't merge quite yet. |
Member
Author
|
ok I fixed the specific error I was having... file monitors were expecting they always receive absolute paths so this fixes that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only works on macos/unix and requires unix sockets. It should not break anything on systems that don't have watchman installed but is preferred on systems that have it.