Skip to content

support pressing enter to trigger a reload after a crash#53

Merged
mmerickel merged 1 commit into
Pylons:masterfrom
mmerickel:trigger-reload-after-crash
Jun 12, 2019
Merged

support pressing enter to trigger a reload after a crash#53
mmerickel merged 1 commit into
Pylons:masterfrom
mmerickel:trigger-reload-after-crash

Conversation

@mmerickel

@mmerickel mmerickel commented Jun 11, 2019

Copy link
Copy Markdown
Member
  • add a wait_main which is invoked in a subprocess after the main worker dies
  • if ENTER is pressed during the wait_main then trigger a reload
  • this also makes the pausing logic more clear after the worker dies
  • skip the reload_interval after a reloader.trigger_reload() invocation from the worker

@mmerickel mmerickel merged commit 80e220a into Pylons:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant