Skip to content

Add shutdown-interval CLI argument#56

Merged
mmerickel merged 4 commits into
Pylons:masterfrom
yeraydiazdiaz:shutdown-interval-cli-arg
Oct 15, 2019
Merged

Add shutdown-interval CLI argument#56
mmerickel merged 4 commits into
Pylons:masterfrom
yeraydiazdiaz:shutdown-interval-cli-arg

Conversation

@yeraydiazdiaz

Copy link
Copy Markdown

Fixes #54

@digitalresistor

Copy link
Copy Markdown
Member

Please sign https://github.com/Pylons/hupper/blob/master/CONTRIBUTORS.txt

@mmerickel this needs a fix in tox.ini to always download the latest version of pip because it can't install pytest at the moment.

@mmerickel

Copy link
Copy Markdown
Member

I can't see a reason to support a float here versus an integer. Sorry for the slowness in reviewing but would you mind making it more strict for now?

Comment thread src/hupper/cli.py Outdated
@mmerickel mmerickel merged commit 83934dd into Pylons:master Oct 15, 2019
@mmerickel

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hupper fails to reload app cleanly on Docker Compose environments

3 participants