Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Passwords List Generator #81

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Passwords List Generator #81

merged 1 commit into from
Oct 1, 2020

Conversation

madhavmehndiratta
Copy link
Contributor

@madhavmehndiratta madhavmehndiratta commented Oct 1, 2020

Description

A Custom Wordlist Generator using Python #80

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madhavmehndiratta

The script works well. Good work! 👍🏻

Changes:

  • Please comment on your code, for better understanding.
  • Explain what leet_mode, and print it, while you ask that question.

Suggestion

  • A better name could be given to the project.

@madhavmehndiratta
Copy link
Contributor Author

Hi @tusharnankani
Thanks for reviewing the project, can you suggest a better name for the project?

@tusharnankani
Copy link
Member

Hi @tusharnankani
Thanks for reviewing the project, can you suggest a better name for the project?

Hi! Since this project is on the lines of Password and not simply a random wordlist generator, then something on those lines.

@AdityaJ7 AdityaJ7 requested review from tusharnankani and removed request for chavarera October 1, 2020 12:42
@tusharnankani
Copy link
Member

Please make the requested changes.

@madhavmehndiratta
Copy link
Contributor Author

Hi, I have tried to comment my code (Though I am not at all good at it) Also, I think the code is clear that anyone with basic python knowledge can easily understand.

@madhavmehndiratta
Copy link
Contributor Author

It should not have any conflicts now

@madhavmehndiratta madhavmehndiratta changed the title Custom Wordlist Generator Passwords List Generator Oct 1, 2020
@mergify mergify bot merged commit 50c2b2b into Python-World:master Oct 1, 2020
@tusharnankani
Copy link
Member

@all-contributors please add @madhavmehndiratta for code

@allcontributors
Copy link
Contributor

@tusharnankani

I've put up a pull request to add @madhavmehndiratta! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants