Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Added Google Search Script #92

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Conversation

NamanJain1902
Copy link
Contributor

Description

Script showing search results of google search.

Fixes #(#90 )

Replace issue_no in the above line, with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • [] I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • [] I have added a working sample/screenshot of the script.

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment your code and follow the functional programming paradigm and include a requirements.txt file which contains the google module.

Also, add a prompt message in the input

@naazneen
Copy link

naazneen commented Oct 1, 2020

Hello, I would like to contribute on this script.

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 1, 2020

Hello, I would like to contribute on this script.

Ah, @naazneen thanks for your interest but @nj1902 is working on it.

You can check the projects that are already present in our repos - this one and the python-min-project repo and submit an issue for a script that you want to add but is not already present.

For any other query drop a comment here or in our WhatsApp group

Thanks

@NamanJain1902
Copy link
Contributor Author

Pl. Review updated PR.

@mergify mergify bot merged commit 9d648d8 into Python-World:master Oct 2, 2020
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 2, 2020

all-contributors please add @nj1902 for code

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 2, 2020

@all-contributors please add @nj1902 for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @nj1902! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants