Lapply not fail writing resource forks to APFS

[MacTroy]

On an APFS volume, writing a resource fork to an existing file using the venerable _PATH_RSRCFORKSPEC (..namedfork/rsrc) shortcut only works if that file already has a resource fork. (?!?!)

Patches lapply with an xattr function that attaches an empty resource fork to the data fork before proceeding.

[magnusviri]

Has anyone else tried this?

[sth0]

I haven’t tried that particular patch. I did create my own patch and then spent a long time testing (way too long as I forgot about pushing the changes).

…

On Dec 28, 2019, at 9:29 PM, James Reynolds ***@***.***> wrote: Has anyone else tried this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJBZKWOOROH5J2F3TDQ3Q3ADQRA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYWIQY#issuecomment-569467971>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB2L4GDMN37PYYBPKRDQ3ADQRANCNFSM4ICRR2XA>.

[MacTroy]

I, too, would love to know if anyone else is using this. :)

At our college, this little patch has allowed us to continue using radmind to provide nightly (and on-demand) updates to ~500 lab and classroom Macs which were upgraded to Mojave in August. These are all heavily-used computers that each have between 70 and 100 apps deployed and we’ve had no problems thus far.

[sth0]

I am trying to reconcile my versions and will look at that patch soon. My current question is (as a git noob) how to issue a pull request. I have pushed my branch to my own (sth0) repository but how do I ask you to pull that branch. I am using Sourcetree as my git interface and it gives the following error: git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags origin refs/heads/sth-b64length:refs/heads/master Pushing to https://github.com/Radmind/radmind.git remote: Permission to Radmind/radmind.git denied to sth0. fatal: unable to access 'https://github.com/Radmind/radmind.git/': The requested URL returned error: 403 Completed with errors, see above

…

-Scott

On Dec 29, 2019, at 7:29 PM, MacTroy ***@***.***> wrote: I, too, would love to know if anyone else is using this. :) At our college, this little patch has allowed us to continue using radmind to provide nightly (and on-demand) updates to ~500 lab and classroom Macs which were upgraded to Mojave in August. These are all heavily-used computers that each have between 70 and 100 apps deployed and we’ve had no problems thus far. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB7345XCG34AXJNTMLLQ3E6HXA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZLY2Y#issuecomment-569556075>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB7IUFET7UUSJ3QKCJDQ3E6HXANCNFSM4ICRR2XA>.

[magnusviri]

I don’t really know myself. I’ve only done it by clicking the edit button for someone else’s repository and it asks if I want to fork and I fork it and then when I make the change it gives me the option to issue the pull request. I believe if you’ve already forked the radmind repository then there should be a button somewhere to issue a pull request. James

…

On Dec 29, 2019, at 7:31 PM, sth0 ***@***.***> wrote: I am trying to reconcile my versions and will look at that patch soon. My current question is (as a git noob) how to issue a pull request. I have pushed my branch to my own (sth0) repository but how do I ask you to pull that branch. I am using Sourcetree as my git interface and it gives the following error: git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags origin refs/heads/sth-b64length:refs/heads/master Pushing to https://github.com/Radmind/radmind.git remote: Permission to Radmind/radmind.git denied to sth0. fatal: unable to access 'https://github.com/Radmind/radmind.git/': The requested URL returned error: 403 Completed with errors, see above -Scott > On Dec 29, 2019, at 7:29 PM, MacTroy ***@***.***> wrote: > > I, too, would love to know if anyone else is using this. :) > > At our college, this little patch has allowed us to continue using radmind to provide nightly (and on-demand) updates to ~500 lab and classroom Macs which were upgraded to Mojave in August. These are all heavily-used computers that each have between 70 and 100 apps deployed and we’ve had no problems thus far. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB7345XCG34AXJNTMLLQ3E6HXA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZLY2Y#issuecomment-569556075>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB7IUFET7UUSJ3QKCJDQ3E6HXANCNFSM4ICRR2XA>. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[sth0]

James, I have a menu item to issue a pull request, but the error is "remote: Permission to Radmind/radmind.git denied to sth0” which I haven’t had on my other git repositories. Is there something that is set up to prevent me from submitting a pull request? Should I be pushing the committed code to the radmind general repository or should I be pushing it to my own personal space repository and asking for a pull from there? I could not create a branch repository on the general radmind repository.

…

-Scott

On Dec 29, 2019, at 10:39 PM, James Reynolds ***@***.***> wrote: I don’t really know myself. I’ve only done it by clicking the edit button for someone else’s repository and it asks if I want to fork and I fork it and then when I make the change it gives me the option to issue the pull request. I believe if you’ve already forked the radmind repository then there should be a button somewhere to issue a pull request. James > On Dec 29, 2019, at 7:31 PM, sth0 ***@***.***> wrote: > > I am trying to reconcile my versions and will look at that patch soon. My current question is (as a git noob) how to issue a pull request. I have pushed my branch to my own (sth0) repository but how do I ask you to pull that branch. > > I am using Sourcetree as my git interface and it gives the following error: > git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags origin refs/heads/sth-b64length:refs/heads/master > Pushing to https://github.com/Radmind/radmind.git > remote: Permission to Radmind/radmind.git denied to sth0. > fatal: unable to access 'https://github.com/Radmind/radmind.git/': The requested URL returned error: 403 > Completed with errors, see above > > -Scott > > > On Dec 29, 2019, at 7:29 PM, MacTroy ***@***.***> wrote: > > > > I, too, would love to know if anyone else is using this. :) > > > > At our college, this little patch has allowed us to continue using radmind to provide nightly (and on-demand) updates to ~500 lab and classroom Macs which were upgraded to Mojave in August. These are all heavily-used computers that each have between 70 and 100 apps deployed and we’ve had no problems thus far. > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB7345XCG34AXJNTMLLQ3E6HXA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZLY2Y#issuecomment-569556075>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB7IUFET7UUSJ3QKCJDQ3E6HXANCNFSM4ICRR2XA>. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or unsubscribe. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB53GZWF23LAXUDMQLTQ3FUN7A5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZQCUA#issuecomment-569573712>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB567Z5ID3URSH6TH6DQ3FUN7ANCNFSM4ICRR2XA>.

[magnusviri]

You won’t be able to modify the general radmind repository. Edit your own and then after you save your edits you can issue a pull request. James

…

On Dec 29, 2019, at 9:30 PM, sth0 ***@***.***> wrote: James, I have a menu item to issue a pull request, but the error is "remote: Permission to Radmind/radmind.git denied to sth0” which I haven’t had on my other git repositories. Is there something that is set up to prevent me from submitting a pull request? Should I be pushing the committed code to the radmind general repository or should I be pushing it to my own personal space repository and asking for a pull from there? I could not create a branch repository on the general radmind repository. -Scott > On Dec 29, 2019, at 10:39 PM, James Reynolds ***@***.***> wrote: > > I don’t really know myself. I’ve only done it by clicking the edit button for someone else’s repository and it asks if I want to fork and I fork it and then when I make the change it gives me the option to issue the pull request. I believe if you’ve already forked the radmind repository then there should be a button somewhere to issue a pull request. > > James > > > > On Dec 29, 2019, at 7:31 PM, sth0 ***@***.***> wrote: > > > > I am trying to reconcile my versions and will look at that patch soon. My current question is (as a git noob) how to issue a pull request. I have pushed my branch to my own (sth0) repository but how do I ask you to pull that branch. > > > > I am using Sourcetree as my git interface and it gives the following error: > > git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags origin refs/heads/sth-b64length:refs/heads/master > > Pushing to https://github.com/Radmind/radmind.git > > remote: Permission to Radmind/radmind.git denied to sth0. > > fatal: unable to access 'https://github.com/Radmind/radmind.git/': The requested URL returned error: 403 > > Completed with errors, see above > > > > -Scott > > > > > On Dec 29, 2019, at 7:29 PM, MacTroy ***@***.***> wrote: > > > > > > I, too, would love to know if anyone else is using this. :) > > > > > > At our college, this little patch has allowed us to continue using radmind to provide nightly (and on-demand) updates to ~500 lab and classroom Macs which were upgraded to Mojave in August. These are all heavily-used computers that each have between 70 and 100 apps deployed and we’ve had no problems thus far. > > > > > > — > > > You are receiving this because you commented. > > > Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB7345XCG34AXJNTMLLQ3E6HXA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZLY2Y#issuecomment-569556075>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB7IUFET7UUSJ3QKCJDQ3E6HXANCNFSM4ICRR2XA>. > > > > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub, or unsubscribe. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB53GZWF23LAXUDMQLTQ3FUN7A5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZQCUA#issuecomment-569573712>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB567Z5ID3URSH6TH6DQ3FUN7ANCNFSM4ICRR2XA>. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[sth0]

I think I know what the problem is… I think I can modify the general repository but only within my own branch. But I am doing most of this on my old home desktop and it can’t handle the newer required github authorization. (My iMac is limited to Mac OS 10.11.6). Let me move my repository to my laptop and see if I can push it and issue a pull request from there.

…

-Scott

On Dec 29, 2019, at 11:31 PM, James Reynolds ***@***.***> wrote: You won’t be able to modify the general radmind repository. Edit your own and then after you save your edits you can issue a pull request. James > On Dec 29, 2019, at 9:30 PM, sth0 ***@***.***> wrote: > > James, > > I have a menu item to issue a pull request, but the error is "remote: Permission to Radmind/radmind.git denied to sth0” which I haven’t had on my other git repositories. > > Is there something that is set up to prevent me from submitting a pull request? > > Should I be pushing the committed code to the radmind general repository or should I be pushing it to my own personal space repository and asking for a pull from there? > > I could not create a branch repository on the general radmind repository. > > -Scott > > > On Dec 29, 2019, at 10:39 PM, James Reynolds ***@***.***> wrote: > > > > I don’t really know myself. I’ve only done it by clicking the edit button for someone else’s repository and it asks if I want to fork and I fork it and then when I make the change it gives me the option to issue the pull request. I believe if you’ve already forked the radmind repository then there should be a button somewhere to issue a pull request. > > > > James > > > > > > > On Dec 29, 2019, at 7:31 PM, sth0 ***@***.***> wrote: > > > > > > I am trying to reconcile my versions and will look at that patch soon. My current question is (as a git noob) how to issue a pull request. I have pushed my branch to my own (sth0) repository but how do I ask you to pull that branch. > > > > > > I am using Sourcetree as my git interface and it gives the following error: > > > git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags origin refs/heads/sth-b64length:refs/heads/master > > > Pushing to https://github.com/Radmind/radmind.git > > > remote: Permission to Radmind/radmind.git denied to sth0. > > > fatal: unable to access 'https://github.com/Radmind/radmind.git/': The requested URL returned error: 403 > > > Completed with errors, see above > > > > > > -Scott > > > > > > > On Dec 29, 2019, at 7:29 PM, MacTroy ***@***.***> wrote: > > > > > > > > I, too, would love to know if anyone else is using this. :) > > > > > > > > At our college, this little patch has allowed us to continue using radmind to provide nightly (and on-demand) updates to ~500 lab and classroom Macs which were upgraded to Mojave in August. These are all heavily-used computers that each have between 70 and 100 apps deployed and we’ve had no problems thus far. > > > > > > > > — > > > > You are receiving this because you commented. > > > > Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB7345XCG34AXJNTMLLQ3E6HXA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZLY2Y#issuecomment-569556075>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB7IUFET7UUSJ3QKCJDQ3E6HXANCNFSM4ICRR2XA>. > > > > > > > > > > — > > > You are receiving this because you commented. > > > Reply to this email directly, view it on GitHub, or unsubscribe. > > > > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB53GZWF23LAXUDMQLTQ3FUN7A5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZQCUA#issuecomment-569573712>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB567Z5ID3URSH6TH6DQ3FUN7ANCNFSM4ICRR2XA>. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or unsubscribe. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB37X6QWIVVGLSPCOX3Q3F2R5A5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZRTPY#issuecomment-569579967>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJB3ZZVJ3VJAT55URPD3Q3F2R5ANCNFSM4ICRR2XA>.

[sth0]

James, I think I figured it out… I was working with a clone instead of a fork. I will get the git terminology straight eventually.

…

-Scott

On Dec 29, 2019, at 11:31 PM, James Reynolds ***@***.***> wrote: You won’t be able to modify the general radmind repository. Edit your own and then after you save your edits you can issue a pull request. James

[tcleamy]

Has anyone else tried this?

We are using the attached patch here at UC Davis. It is working well . We used to see a lot of errors applying transcripts with resource forks and had to try to comment out all those files. Now it just works!

So if you are still looking for feedback before merging the change into the master branch we say go for it.

One quick note. gcc complained since rsrcresult was declared but never used:

  retr.c:433:6: warning: unused variable 'rsrcresult' [-Wunused-variable]
          int rsrcresult = fsetxattr( dfd, XATTR_RESOURCEFORK_NAME, &rsrcvalue,

So it might make sense to do some error checking on the result. Maybe like:

	if ( rsrcresult == -1 ) {
            fprintf( stderr,"%s: Unable to create resource fork %s\n",rsrc_path, strerror( errno ));
	    returnval = -1;
	    goto error2;
	}

[sth0]

Great. I will look at that suggestion soon.

…

-Scott

On Feb 5, 2020, at 6:31 PM, tcleamy ***@***.***> wrote: Has anyone else tried this? We are using the attached patch here at UC Davis. It is working well . We used to see a lot of errors applying transcripts with resource forks and had to try to comment out all those files. Now it just works! So if you are still looking for feedback before merging the change into the master branch we say go for it. One quick note. gcc complained since rsrcresult was declared but never used: retr.c:433:6: warning: unused variable 'rsrcresult' [-Wunused-variable] int rsrcresult = fsetxattr( dfd, XATTR_RESOURCEFORK_NAME, &rsrcvalue, So it might make sense to do some error checking on the result. Maybe like: if ( rsrcresult == -1 ) { fprintf( stderr,"%s: Unable to create resource fork %s\n",rsrc_path, strerror( errno )); returnval = -1; goto error2; } — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#331?email_source=notifications&email_token=AADSJB77YTUSERCQ2LXS7RTRBND5RA5CNFSM4ICRR2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5L2QI#issuecomment-582663489>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSJBYXS2J3V745WXJBOITRBND5RANCNFSM4ICRR2XA>.

[magnusviri]

I'm merging this finally.