Skip to content

Update regex to allow longer and multi-part TLDs #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

loiswells97
Copy link
Contributor

Status

  • Closes add issue numbers or delete
  • Related to add issue numbers or delete

Points for consideration:

  • Security
  • Performance

What's changed?

Description of what's been done - bullets are often best

Steps to perform after deploying to production

If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, a migration, or upgrading a Gem. That kind of thing.

@cla-bot cla-bot bot added the cla-signed label Oct 24, 2024
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-fix-url-re-m1mzg3 October 24, 2024 15:40 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-fix-url-re-m1mzg3 October 24, 2024 15:42 Inactive
@loiswells97 loiswells97 self-assigned this Oct 24, 2024
@loiswells97 loiswells97 added the bug Something isn't working label Oct 24, 2024
Copy link
Contributor

@sra405 sra405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense to me

@loiswells97 loiswells97 merged commit c06797f into main Oct 25, 2024
3 checks passed
@loiswells97 loiswells97 deleted the fix-url-regex branch October 25, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants