Support multiple teachers per class #456
Conversation
loiswells97
changed the title
loiswells97
changed the title
| @@ -105,6 +106,10 @@ def school_owner? | |||
| school && current_user.school_owner?(school) | |||
| end | |||
|
|
|||
| def class_teacher?(project) | |||
| project.lesson_id.present? && project.lesson.school_class.present? && project.lesson.school_class.teacher_ids.include?(current_user.id) | |||
There was a problem hiding this comment.
do you need project.lesson_id.present?? I think that's implicit by project.lesson existing, since the relationship wouldn't exist otherwise
There was a problem hiding this comment.
This was more to be on the safe side to cover off the cases where it's not a school project
app/models/school_class.rb
Outdated
| @@ -2,12 +2,15 @@ | |||
|
|
|||
| class SchoolClass < ApplicationRecord | |||
| belongs_to :school | |||
| has_many :members, class_name: :ClassMember, inverse_of: :school_class, dependent: :destroy | |||
| has_many :students, class_name: :ClassStudent, inverse_of: :school_class, dependent: :destroy | |||
| has_many :class_teachers, class_name: :ClassTeacher, inverse_of: :school_class, dependent: :destroy | |||
There was a problem hiding this comment.
why use :students and then :class_teachers instead of :teachers or vice versa? going with one or the other would be nice for consistency
There was a problem hiding this comment.
Ah yes, that would simplify things, thanks 👍
| :name, | ||
| :created_at, | ||
| :updated_at | ||
| ) | ||
|
|
||
| json.teacher_name(teacher&.name) | ||
| json.teachers(teachers) do |teacher| | ||
| if teacher.present? |
There was a problem hiding this comment.
there is already a _school_teacher.json.builder template you can use here and in the show template, you might just need to make the email optional
What's Changed?
ClassTeachermodel which allows classes to have multiple teachersClassmodel now accepts nested attributes forClassTeachersClassMembermodel has been renamed toClassStudentto provide consistency with the approach forSchoolStudent,SchoolMemberetc.ClassMemberoperations will now deal with both teachers and students in keeping with theSchoolMembermodulecloses #463