-
Notifications
You must be signed in to change notification settings - Fork 5
319-bulk-student-validation #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Status - Ready for review ## What's changed? - Only try and decrypt the password if a password is passed, since resetting and updating student details use the same endpoint ## Steps to perform after deploying to production N/A
conorriches
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very nice, I only have a couple of thoughts but this looks great :D
spec/features/school_student/creating_a_batch_of_school_students_spec.rb
Outdated
Show resolved
Hide resolved
spec/features/school_student/creating_a_batch_of_school_students_spec.rb
Outdated
Show resolved
Hide resolved
…ts_spec.rb Co-authored-by: Conor <[email protected]>
…ts_spec.rb Co-authored-by: Conor <[email protected]>
Remove comment
conorriches
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
Steps to perform after deploying to production
N/A