Skip to content

319-bulk-student-validation #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 15, 2024
Merged

319-bulk-student-validation #458

merged 15 commits into from
Nov 15, 2024

Conversation

danhalson
Copy link
Contributor

Status

What's changed?

  • Handles validations from profile when creating bulk students

Steps to perform after deploying to production

N/A

@cla-bot cla-bot bot added the cla-signed label Nov 7, 2024
@danhalson danhalson self-assigned this Nov 7, 2024
@danhalson danhalson temporarily deployed to editor-api-p-319-bulk-s-gguazd November 7, 2024 17:34 Inactive
@danhalson danhalson marked this pull request as draft November 7, 2024 17:34
danhalson and others added 6 commits November 11, 2024 16:16
## Status

- Ready for review

## What's changed?

- Only try and decrypt the password if a password is passed, since
resetting and updating student details use the same endpoint

## Steps to perform after deploying to production

N/A
@danhalson danhalson marked this pull request as ready for review November 13, 2024 11:38
Copy link
Contributor

@conorriches conorriches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very nice, I only have a couple of thoughts but this looks great :D

Copy link
Contributor

@conorriches conorriches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@danhalson danhalson merged commit b9f7ee2 into main Nov 15, 2024
3 checks passed
@danhalson danhalson deleted the 319-bulk-student-validation branch November 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants