Skip to content

2 Extend API for auto save #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 28, 2022
Merged

2 Extend API for auto save #86

merged 9 commits into from
Nov 28, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Nov 15, 2022 •
edited by sHtev
Loading

What's changed?

  • Minor docker changes, gems should rebuild on first run
  • Moved operations to /lib for more control in autoloader, can discuss this esp. in context of a new command pattern
  • Require authentication for create project and add identifier to initial creation
  • Update to syntax (as per rubocop) for new 3.1 features, e.g., hash literal/arg omission
  • Remove create action on default project

closes #85

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-85--hl31vy November 15, 2022 10:09 Inactive
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@sHtev sHtev force-pushed the issues/85-2_Extend_API_for_auto_save branch from 17519ab to 2b2076f Compare November 18, 2022 18:13
@sHtev sHtev force-pushed the issues/85-2_Extend_API_for_auto_save branch from 2b2076f to 0c51b00 Compare November 18, 2022 18:17
@sHtev sHtev requested review from patch0 and loiswells97 November 25, 2022 16:26
@sHtev sHtev self-assigned this Nov 25, 2022
@raspberrypigithubbot
Copy link

@sHtev sHtev marked this pull request as ready for review November 25, 2022 16:34
patch0
patch0 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks OK, just wondering about the knock-on effects for the removal of the default component in the project create operation.

@sHtev sHtev merged commit b077470 into main Nov 28, 2022
@sHtev sHtev deleted the issues/85-2_Extend_API_for_auto_save branch November 28, 2022 09:53
@grega grega unassigned sHtev Dec 19, 2022
floehopper added a commit that referenced this pull request May 21, 2025
@floehopper
WIP: Use stricter more idiomatic params parsing
75fab8e 
The original version was copied from
`Api::ProjectsController#base_params`, but that seems to be an
abberation introduced [1] for no obviously discernable reason.

[1]: #86
floehopper added a commit that referenced this pull request May 22, 2025
@floehopper
Strict param parsing for Api::PublicProjectsController
0ca3b3d 
The original version was copied from
`Api::ProjectsController#base_params`, but that seems to be an
abberation introduced [1] for no obviously discernable reason. Using
`ActionController::Parameters#require` [2] is more idiomatic Rails.

[1]: #86
[2]: https://api.rubyonrails.org/v7.1.3.4/classes/ActionController/Parameters.html#method-i-require
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patch0 patch0 patch0 approved these changes

@loiswells97 loiswells97 Awaiting requested review from loiswells97

Assignees
No one assigned
Labels
API services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 Extend API for auto save
4 participants
@raspberrypigithubbot @patch0 @sHtev @raspberrypiherokubot