Fix skulpt support for output panels attribute #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
temporarily deployed
to
previews/1158/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1158/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1158/merge
GitHub Actions
Inactive
loiswells97
changed the title
loiswells97
temporarily deployed
to
previews/1158/merge
GitHub Actions
Inactive
danhalson
reviewed
Jan 6, 2025
| @@ -93,7 +93,10 @@ const PythonRunner = () => { | |||
| return ( | |||
| <> | |||
| <PyodideRunner active={activeRunner === "pyodide"} /> | |||
| <SkulptRunner active={activeRunner === "skulpt"} /> | |||
| <SkulptRunner | |||
There was a problem hiding this comment.
Wonder if it's worth adding a simple test to check the outputPanels prop is getting added? just for a bit of regression coverage (and to help avoid it getting missed in the future)
There was a problem hiding this comment.
Thanks Dan, I've added a couple of tests to check this (although in a bit of a roundabout way, as I think React Testing Library doesn't let you test which props are on components, just what's in the DOM annoyingly)
loiswells97
temporarily deployed
to
previews/1158/merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.