Update-output-only-branch #907

sra405 · 2024-01-26T12:05:18Z

No description provided.

- Utilisting existing filename from `kramdown` for the code block - Making the instructions progress bar more in line with the designs

Part of [#2428](RaspberryPiFoundation/projects-ui#2428) - css strings can be passed to the WebComponent through a `hostStyle` prop, allowing the ShadowDOM to receive styles from the host app.

closes #775 --------- Co-authored-by: sra405 <[email protected]> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Adams <[email protected]>

closes #778 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #817 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #786 --------- Co-authored-by: magdalenajadach <[email protected]> Co-authored-by: Magdalena Jadach <[email protected]>

- adds a custom event to notify Projects when the quiz is loaded

closes #813 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #783 --------- Co-authored-by: maxelkins <[email protected]> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #804 Changes: - added `loadRemix` functionality - user state comes from separate `localStorageUser` due to delays in updating state - if logged in `loadRemix` functionality will be called once - if `loadRemix` fails it falls back to loading the base starter code - loading the cache is conditional on either `remixLoad` failing on now user object being set --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Scott <[email protected]>

closes #815 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: MagdalenaJadach <[email protected]>

closes #826 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #838 Notes: Only an issue on Firefox so check multiple browsers with sidebar open and closed --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Adams <[email protected]>

closes #836 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

…854) closes #840 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #839 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #743 The idea is to intercept editor actions (i.e. actions that could call the API) and update the user object in state prior to that call being made. That way if the user object changes for whatever reason (like cred renewal) the latest user object will be used for the API call

closes #846 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #834 - ProgressBar is added to quizzes - Quizzes increment the currentStepPosition when they're complete so that the next step can be rendered - Quiz logic refactored to remove a useEffect() and `quizReady` state --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Pete Simonovic <[email protected]> Co-authored-by: Lois Wells <[email protected]>

closes #842 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

<img width="412" alt="Screenshot 2023-12-21 at 15 18 42" src="https://github.com/%3Ca%20href="https://github.com/RaspberryPiFoundation/editor-ui/assets/88904316/dab26538-ccae-4caa-9efd-9944a2cc1500">https://github.com/RaspberryPiFoundation/editor-ui/assets/88904316/dab26538-ccae-4caa-9efd-9944a2cc1500"> closes #845 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: MagdalenaJadach <[email protected]>

closes #841 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: MagdalenaJadach <[email protected]>

closes #844 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: MagdalenaJadach <[email protected]>

Currently due to the styling changes required to maximise the height of the web component in Firefox the standalone editor took up too much space (didn't account for the top nav). This fix applies the required `min-block-size` only to the web component

Co-authored-by: MagdalenaJadach <[email protected]>

closes #814 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Adams <[email protected]>

Before: ![Screenshot 2024-01-04 at 15 41 01](https://github.com/RaspberryPiFoundation/editor-ui/assets/88904316/03107cc5-4729-4ee5-a747-b4a115fd1d4c) After: <img width="321" alt="Screenshot 2024-01-04 at 15 41 23" src="https://github.com/%3Ca%20href="https://github.com/RaspberryPiFoundation/editor-ui/assets/88904316/3502d136-36bc-42d5-9f27-63c721df7f7b">https://github.com/RaspberryPiFoundation/editor-ui/assets/88904316/3502d136-36bc-42d5-9f27-63c721df7f7b">

Oops

Project site integration changes

This PR fixes and extends the assets url/blob replacements throughout css and html: - Allows multiple url replacements in css - Generalises the attribute replacement and applies to `data-src` attributes too

closes #829 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Fix so anything other than explicitly setting the boolean attributes as false is taken as true

closes #882 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Allows mobile users to save their project and remix in place of auto remixing (#843)

Minor updates for project site integration

closes #733 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Magdalena Jadach <[email protected]> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Adams <[email protected]>

closes #889 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Scott <[email protected]>

… 3.11.1 to 4.0.0 (#895) We need to be able to conditionally set headers for pyodideWorker.js in pull request #893 but this feature isn’t supported in webpack-dev-server 3.x.x. We therefore need to upgrade to version 4.0.0 which allows a function to be provided in the headers option. When attempting this upgrade, I ran into [this issue](storybookjs/storybook#22431) and only managed to resolve it by also updating yarn to version 3. I’ve tried to follow the migration guide here: https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md

closes #897 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]>

## [0.21.2] - 2024-01-23 ### Changed - Minor copy changes to HTML add file modal - Toggle errors sent via apiCallHandler off (#890) - Upgrade webpack-dev-server to 4.0.0 to support conditional headers - Upgrade yarn to 3.4.1 to workaround a string-width issue ### Fixed - Editor input not focussing on iPad (#898)

Yarn v3 needs: - activating inside Dockerfile - volumes need mounting in docker-compose ### Notes - `yarnrc.yml` could be different between environments (i.e. local machine and container) so ignoring the file in the repo and generating one on build in docker

github-actions · 2024-01-26T12:07:14Z

Github Run 7667790753
Test coverage: 84%

loiswells97 · 2024-01-26T12:30:56Z

CHANGELOG.md

+## [0.21.2] - 2024-01-23
+
+### Changed
+
+- Minor copy changes to HTML add file modal
+- Toggle errors sent via apiCallHandler off (#890)
+- Upgrade webpack-dev-server to 4.0.0 to support conditional headers
+- Upgrade yarn to 3.4.1 to workaround a string-width issue
+
+### Fixed
+
+- Editor input not focussing on iPad (#898)
+
+## [0.21.1] - 2024-01-11


This bit's here twice (see below)

github-actions · 2024-01-26T12:42:12Z

Github Run 7668159025
Test coverage: 84%

loiswells97

👍

github-actions · 2024-01-26T13:38:57Z

Github Run 7668780553
Test coverage: 84%

loiswells97 and others added 30 commits December 8, 2023 14:54

Minor instructions styling fixes (#808)

7bf411a

- Utilisting existing filename from `kramdown` for the code block - Making the instructions progress bar more in line with the designs

Issue 2428 host styles added for web component (#811)

ee55a23

Part of [#2428](RaspberryPiFoundation/projects-ui#2428) - css strings can be passed to the WebComponent through a `hostStyle` prop, allowing the ShadowDOM to receive styles from the host app.

Enable the project bar in the web component (#799)

e9644d7

closes #775 --------- Co-authored-by: sra405 <[email protected]> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Adams <[email protected]>

Get modals rendering in the web component (#802)

140ed61

closes #778 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Web component context menu styling (#819)

a1851ef

closes #817 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Adding plausible to web component login button (#818)

11c9cb8

Accessibility: Linter issues with the border, width etc. (#787)

83427fc

closes #786 --------- Co-authored-by: magdalenajadach <[email protected]> Co-authored-by: Magdalena Jadach <[email protected]>

Issues/812 quiz custom event (#828)

82f2c7d

- adds a custom event to notify Projects when the quiz is loaded

Web component toasts (#822)

081d8c5

closes #813 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Web component save button on mobile (#784)

06d8cdf

closes #783 --------- Co-authored-by: maxelkins <[email protected]> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Miscellaneous styling bugs (#827)

dac0fa7

closes #826 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

fix dark mode button theming (#850)

f3d835e

closes #836 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Integration: Instructions pagination styles need finishing (#855)

5de17cd

closes #839 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Integration: Save panel spacing (#859)

8e64228

closes #846 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Integration: Font-family stack order incorrect (#857)

92119f3

closes #842 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Add list support for host_styles in web component (#863)

0d0f4b8

Co-authored-by: MagdalenaJadach <[email protected]>

Project sidebar instructions (#823)

6ea765b

closes #814 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Adams <[email protected]>

InstructionsPanel has a random debugger (#870)

d50d84f

Oops

Release v0.21.0 (#871)

f5bd46b

Project site integration changes

sra405 and others added 14 commits January 11, 2024 10:03

Fix blob replacement for css and html attributes (#877)

af23570

This PR fixes and extends the assets url/blob replacements throughout css and html: - Allows multiple url replacements in css - Generalises the attribute replacement and applies to `data-src` attributes too

Project bar styling fixes (#869)

f2c2490

closes #829 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Fix web-component boolean attributes (#881)

dff625e

Fix so anything other than explicitly setting the boolean attributes as false is taken as true

fix code block rogue padding (#883)

0ba2c54

closes #882 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]> Co-authored-by: Lois Wells <[email protected]>

Added a save button to DownloadPanel (#872)

77b2268

Allows mobile users to save their project and remix in place of auto remixing (#843)

v0.21.1 (#884)

43f87d8

Minor updates for project site integration

fix(copy): minor copy change to html add file modal

fbfa670

Turn off error capturing in our project_errors table (#890)

6f20db3

closes #889 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Scott <[email protected]>

fix iPad codemirror issues (#898)

82d5c13

closes #897 --------- Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com> Co-authored-by: Lois Wells <[email protected]>

Merge branch 'main' into update-output-only-branch

ae5f51f

loiswells97 reviewed Jan 26, 2024

View reviewed changes

changelog

ed51520

sra405 temporarily deployed to previews/update-output-only-branch January 26, 2024 12:40 — with GitHub Actions Inactive

loiswells97 approved these changes Jan 26, 2024

View reviewed changes

sra405 merged commit a320956 into output-only-wc Jan 26, 2024

sra405 deleted the update-output-only-branch branch January 26, 2024 13:35

sra405 restored the update-output-only-branch branch January 26, 2024 13:36

sra405 deployed to previews/update-output-only-branch January 26, 2024 13:36 — with GitHub Actions View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update-output-only-branch #907

Update-output-only-branch #907

Uh oh!

sra405 commented Jan 26, 2024

Uh oh!

github-actions bot commented Jan 26, 2024

Uh oh!

loiswells97 Jan 26, 2024

Uh oh!

github-actions bot commented Jan 26, 2024

Uh oh!

loiswells97 left a comment

Uh oh!

github-actions bot commented Jan 26, 2024

Uh oh!

Uh oh!

Update-output-only-branch #907

Update-output-only-branch #907

Uh oh!

Conversation

sra405 commented Jan 26, 2024

Uh oh!

github-actions bot commented Jan 26, 2024

Uh oh!

loiswells97 Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 26, 2024

Uh oh!

loiswells97 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 26, 2024

Uh oh!

Uh oh!