Matrix stops working when "off" command issued upon deletion #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regression was introduced in PR RaspberryPiFoundation#121 where all devices issue the "off" command to themselves upon destruction. Using the "off" command is specifically avoided in `BuildHAT.shutdown()` with an exception built into the type identifier for the Matrix
|
Good spot! Thanks for that |
mutesplash
added a commit
to mutesplash/python-build-hat
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It stays non-functional until it's reconnected. This regression was introduced in PR #121 where all devices issue the "off" command to themselves upon destruction. Using the "off" command is specifically avoided in
BuildHAT.shutdown()with an exception built into the type identifier for the Matrix but a similar carveout inDevice.__del__()has not been made.