-
Notifications
You must be signed in to change notification settings - Fork 21
Improve error checking to Matrix parameters #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Matrix will override off() and call clear() on itself, since "port 0; off" crashes the device
Just like set_pixel
Updated! |
I guess I better get flake8 installed if I want this merged. |
Hey, sorry about that, I've just been working on linting the code, you'll need -
Then you can do: 'PYTHONPATH=. flake8 .' from the main part of the repo. |
I mean seriously, how old is this bug? pylint-dev/pylint#1498
This now fails to run the example in docs for me. With:
Also at the moment I'm not really using the type annotation feature. I think staticmethod should be used rather than classmethod. |
Ugh, these tuples... I put the type annotations in to make the linter be quiet. If you'd rather use the # directives, I'll change it back. I'll also use the staticmethod. |
Ooookay, turned out those didn't help the linter anyway! It should work now? |
De-duplicates code and also allows set_pixels to accept (str,int) as pixel specifications
Allow set_pixels() to defer display updates like set_pixel() does
Also, remove the exception in Device.off() for the Matrix by overriding it