Skip to content

Expose release property to allow motor to hold position #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions buildhat/motors.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,28 @@ def float(self):
"""Float motor"""
self.pwm(0)

@property
def release(self):
"""Determine if motor is released after running, so can be turned by hand

:getter: Returns whether motor is released, so can be turned by hand
:setter: Sets whether motor is released, so can be turned by hand
:return: Whether motor is released, so can be turned by hand
:rtype: bool
"""
return self._release

@release.setter
def release(self, value):
"""Determine if the motor is released after running, so can be turned by hand

:param value: Whether motor should be released, so can be turned by hand
:type value: bool
"""
if not isinstance(value, bool):
raise MotorError("Must pass boolean")
self._release = value


class MotorPair:
"""Pair of motors
Expand All @@ -438,6 +460,7 @@ def __init__(self, leftport, rightport):
self._leftmotor = Motor(leftport)
self._rightmotor = Motor(rightport)
self.default_speed = 20
self._release = True

def set_default_speed(self, default_speed):
"""Set the default speed of the motor
Expand Down Expand Up @@ -537,3 +560,27 @@ def run_to_position(self, degreesl, degreesr, speed=None, direction="shortest"):
th2.start()
th1.join()
th2.join()

@property
def release(self):
"""Determine if motors are released after running, so can be turned by hand

:getter: Returns whether motors are released, so can be turned by hand
:setter: Sets whether motors are released, so can be turned by hand
:return: Whether motors are released, so can be turned by hand
:rtype: bool
"""
return self._release

@release.setter
def release(self, value):
"""Determine if motors are released after running, so can be turned by hand

:param value: Whether motors should be released, so can be turned by hand
:type value: bool
"""
if not isinstance(value, bool):
raise MotorError("Must pass boolean")
self._release = value
self._leftmotor.release = value
self._rightmotor.release = value