Skip to content

Improve sensor interval #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Improve sensor interval #192

merged 6 commits into from
Feb 24, 2023

Conversation

chrisruk
Copy link
Contributor

@chrisruk chrisruk commented Feb 9, 2023

No description provided.

@chrisruk chrisruk force-pushed the sensorinterval branch 2 times, most recently from f83f38f to 39144bb Compare February 10, 2023 14:48
@chrisruk chrisruk marked this pull request as ready for review February 23, 2023 14:04
Copy link

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments

@chrisruk chrisruk force-pushed the sensorinterval branch 2 times, most recently from d6f1ded to c209d05 Compare February 24, 2023 12:05
This is so that we don't end up with a busy loop, which interfers with
processing serial data from another thread.  I think if there wasn't a GIL
this problem might not exist.
Copy link

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@chrisruk chrisruk merged commit 9c1dbb9 into main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants