Skip to content

1.x: add marble diagram to UnicastSubject, fix javadoc #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

akarnokd
Copy link
Member

This PR fixes a missing javadoc entry for <T> in UnicastSubject and adds a marble diagram to the class itself:

Image

@akarnokd akarnokd added this to the 1.3 milestone Mar 21, 2017
@codecov
Copy link

codecov bot commented Mar 21, 2017

Codecov Report

Merging #5209 into 1.x will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x    #5209      +/-   ##
============================================
+ Coverage     84.38%   84.39%   +0.01%     
- Complexity     2882     2883       +1     
============================================
  Files           290      290              
  Lines         18123    18123              
  Branches       2479     2479              
============================================
+ Hits          15293    15295       +2     
+ Misses         1963     1956       -7     
- Partials        867      872       +5
Impacted Files Coverage Δ Complexity Δ
src/main/java/rx/subjects/UnicastSubject.java 84.56% <ø> (ø) 9 <0> (ø) ⬇️
...ain/java/rx/internal/operators/OnSubscribeAmb.java 79.13% <0%> (-5.04%) 13% <0%> (ø)
...ain/java/rx/internal/schedulers/SchedulerWhen.java 83.78% <0%> (-4.06%) 4% <0%> (ø)
...rx/internal/operators/OnSubscribeFromIterable.java 91.46% <0%> (-2.44%) 5% <0%> (ø)
.../rx/internal/schedulers/CachedThreadScheduler.java 87.37% <0%> (-1.95%) 6% <0%> (ø)
...n/java/rx/subscriptions/CompositeSubscription.java 75.32% <0%> (-1.3%) 24% <0%> (ø)
...in/java/rx/internal/operators/OperatorGroupBy.java 90.81% <0%> (-0.71%) 5% <0%> (ø)
.../java/rx/internal/operators/BackpressureUtils.java 70.45% <0%> (+2.27%) 28% <0%> (+1%) ⬆️
.../rx/internal/operators/OperatorWindowWithTime.java 48.48% <0%> (+6.43%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6824c1...1523bf8. Read the comment docs.

@akarnokd akarnokd merged commit d1f20a1 into ReactiveX:1.x Mar 21, 2017
@akarnokd akarnokd deleted the UnicastSubject1xDiagram branch March 21, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants