Skip to content

2.x: improve the documentation of Schedulers utility class. #5223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

akarnokd
Copy link
Member

This PR improves the javadoc of the io.reactivex.schedulers.Schedulers utility class plus adds a missing SchedulerSupport constant for the single() scheduler.

Let me know if something needs further explanation (or some new case needs explanation).

Related: #5145.

@codecov
Copy link

codecov bot commented Mar 24, 2017

Codecov Report

Merging #5223 into 2.x will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x    #5223     +/-   ##
===========================================
- Coverage     96.01%   95.91%   -0.1%     
+ Complexity     5747     5740      -7     
===========================================
  Files           628      628             
  Lines         41085    41085             
  Branches       5698     5698             
===========================================
- Hits          39446    39406     -40     
- Misses          657      679     +22     
- Partials        982     1000     +18
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/schedulers/Schedulers.java 100% <ø> (ø) 10 <0> (ø) ⬇️
...a/io/reactivex/processors/SerializedProcessor.java 91.48% <0%> (-6.39%) 27% <0%> (-1%)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 93.87% <0%> (-6.13%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 89.55% <0%> (-5.98%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 92.45% <0%> (-5.67%) 23% <0%> (-2%)
...rnal/operators/completable/CompletableTimeout.java 94% <0%> (-4%) 2% <0%> (ø)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 89.83% <0%> (-3.21%) 5% <0%> (ø)
...activex/internal/operators/single/SingleCache.java 97.05% <0%> (-2.95%) 23% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 96.42% <0%> (-2.68%) 2% <0%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59dc7a3...a3bfa80. Read the comment docs.

@akarnokd akarnokd merged commit 3f6e570 into ReactiveX:2.x Mar 24, 2017
@akarnokd akarnokd deleted the SchedulersDoc2x branch March 24, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants