Add app filter experimental enable function #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
force-pushed
the
app-filter-enablement
branch
from
bc351dd to
1e61ded
Compare
Hyperkid123
previously approved these changes
Jan 28, 2021
karelhala
force-pushed
the
app-filter-enablement
branch
2 times, most recently
from
48d842a to
7a38674
Compare
karelhala
force-pushed
the
app-filter-enablement
branch
from
7a38674 to
d5b5eb5
Compare
Hyperkid123
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App filter enablement
We don't want to change how we promote envs and cherry pick commits not related to appFilter, instead let's push appFilter code to any environment and just hide it behind feature flag. If you want to enable the appFilter for local development new enable function
insights.chrome.enable.appFilterhas been added.