Add no access page for app settings #506
Conversation
|
Hey guys! Do let me know if anything can be improved here! |
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 59.76% 59.92% +0.15%
==========================================
Files 43 43
Lines 778 776 -2
Branches 146 145 -1
==========================================
Hits 465 465
+ Misses 256 255 -1
+ Partials 57 56 -1
|
karelhala
left a comment
karelhala
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks solid, we just have to fix couple of problems and are good to go!
…ts-chrome into add-no-access-page
karelhala
left a comment
karelhala
left a comment
There was a problem hiding this comment.
Looking good! One small thing about checking if user is entitled not only to insights in settings but for any app. I am fine with keeping this as is, we just have to mark this for future improvement for other apps as well.
|
@karelhala Your suggestion works great! I just had to tweak the logic a little bit and grant access to pages like @karelhala @ryelo this is up for re-review, I think! Let me know if any improvements needed to be made here! |
karelhala
left a comment
karelhala
left a comment
There was a problem hiding this comment.
Looking good! One small improvmement and we are golden. Good point about including untrackedApps as well.
|
@karelhala I think this should be good now. Let me know if you see anything off here! |
…ts-chrome into add-no-access-page
|
@ryelo @karelhala Looks like everything was addressed. Let me know if things needed to be changed here! |
4 participants
Jira: Here