Move to GitHub Workflow #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
move-to-gh
branch
5 times, most recently
from
e23bfec to
d28f581
Compare
mshriver
force-pushed
the
move-to-gh
branch
6 times, most recently
from
2cbc4da to
6194939
Compare
Changes were made by pre-commit, not me.
remove httpserver use, run podman containers for selenium and nginx
issue and PR open to fix it
mshriver
commented
Feb 15, 2022
| uses: pypa/[email protected] | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.pypi_wt_pf }} |
Collaborator
Author
There was a problem hiding this comment.
Secret added at repository level
Some sphinx imports have moved with recent versions Added sys.path modification for autodoc Though the build is clean, the docs contents aren't working correctly. Same thing is happening in wt.pf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize a bit, bringing things up-to-date with wt.core standards.
Use pre-commit. wt.core is using mypy, which caused some failures, so I excluded it (for now).
Remove tox and travis and use a github workflow for the PR and deploy patterns.
Testing
I opened this branch as a PR against my own fork, where the workflow will actually execute. Should all be green there now, giving me confidence the pull request workflow will work here.
The deploy workflow has a secret that needs to be added to GH for pypi push.
mshriver#1
Docs
I've cleaned up and updated the sphinx conf, but the indicies aren't building correctly. Its the same behavior as what's in wt.pf4, and I'd like to handle fixing both of them in a PR other than this one.