Stop updating on conflict if update_condition is False but not None
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users of this library set `update_condition=0` on `upsert` for not updating anything on conflict. The `upsert` documentation says: > update_condition: > Only update if this SQL expression evaluates to true. A value evaluating to Python `False` is ignored while the documentation says no update will be done. [#186513018]
|
@Photonios: See the task for details. Might be either abuse of the API (= we should change the documentation) or an uncovered edge case (= this PR should be merged). |
Photonios
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users of this library set
update_condition=0onupsertfor not updating anything on conflict.The
upsertdocumentation says:A value evaluating to Python
Falseis ignored while the documentation says no update will be done.[#186513018]