Skip to content

[ci] Do not stale issues/prs assigned to any milestone #15259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Feb 9, 2025

User description

GitHub workflow stales the issues and PRs what we really want to address, kind of in backlog.

Motivation and Context

Now this workflow will skip the items assigned to any milestone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Updated GitHub workflow to exempt issues/PRs with milestones from being marked stale.

  • Added exempt-milestones parameter to the stale.yml workflow configuration.


Changes walkthrough 📝

Relevant files
Configuration changes
stale.yml
Update stale workflow to exempt milestone items                   

.github/workflows/stale.yml

  • Added exempt-milestones parameter to prevent staling
    milestone-assigned items.
  • Ensures issues/PRs with milestones are not marked stale or closed
    automatically.
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    qodo-merge-pro bot commented Feb 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 9, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Ensure consistent milestone exemption rules

    The exempt-milestones parameter should be applied to both stale action
    configurations to ensure consistent behavior across all stale checks.

    .github/workflows/stale.yml [27-30]

     - uses: actions/stale@v9
          with:
            close-issue-message: 'This issue was closed because we did not receive any additional information after 14 days.'
            stale-issue-label: 'R-awaiting answer'
    +       exempt-milestones: '*'
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies an inconsistency where milestone exemption is only applied to one stale action but not both, which could lead to inconsistent handling of milestone-assigned items. Adding the exemption to both actions ensures uniform behavior.

    Medium

    Copy link
    Member

    @VietND96 VietND96 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    While reading https://github.com/actions/stale, I don't see the wildcard '*' can work with that config.
    I see another might help

    exempt-all-milestones
    If set to true, the issues or the pull requests with a milestone will not be marked as stale automatically.
    
    Priority over exempt-milestones.
    
    Default value: false
    

    Signed-off-by: Viet Nguyen Duc <[email protected]>
    @VietND96 VietND96 merged commit 55ff83d into SeleniumHQ:trunk Feb 10, 2025
    3 of 4 checks passed
    @VietND96
    Copy link
    Member

    I fixed and merged.

    @nvborisenko nvborisenko deleted the ci-stale-milestone branch February 20, 2025 10:38
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    )
    
    * [ci] Do not stale issues/prs assigned to any milestone
    * Use config exempt-all-milestones
    
    ---------
    
    Signed-off-by: Viet Nguyen Duc <[email protected]>
    Co-authored-by: Viet Nguyen Duc <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants