Skip to content

Upgraded rules_cc Version 0.1.0 > 0.1.1 #15278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

shbenzer
Copy link
Contributor

@shbenzer shbenzer commented Feb 12, 2025

User description

Motivation and Context

Upgrading yanked version - fixes CI Workflow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix, Configuration changes


Description

  • Upgraded rules_cc dependency from version 0.1.0 to 0.1.1.

  • Addressed CI workflow issues caused by the yanked version.


Changes walkthrough 📝

Relevant files
Configuration changes
MODULE.bazel
Updated `rules_cc` dependency version in Bazel module       

MODULE.bazel

  • Updated rules_cc dependency version from 0.1.0 to 0.1.1.
  • Ensured compatibility with the latest rules_cc release.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @shs96c shs96c left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM. Thank you!

    @shbenzer
    Copy link
    Contributor Author

    network-firefox-beta has been failing for a bit - unrelated

    @shbenzer shbenzer merged commit 2bcc405 into SeleniumHQ:trunk Feb 12, 2025
    8 of 9 checks passed
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants