Skip to content

Missing closing parentheses #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Missing closing parentheses #1165

merged 3 commits into from
Sep 19, 2022

Conversation

TDroogers
Copy link
Contributor

@TDroogers TDroogers commented Sep 12, 2022

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

A closing parentheses was missing in the documentation, resulting in a build error.

Motivation and Context

It is annoying.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)
  • Fixed typo

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 0b3011c
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6320880844e081000ccff96c
😎 Deploy Preview https://deploy-preview-1165--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TDroogers ,

Thank you for raising the PR.

Can you add similar changes in translated pages which are other than in English!

@TDroogers
Copy link
Contributor Author

Sure

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TDroogers !

@harsha509 harsha509 merged commit f2c2a0e into SeleniumHQ:trunk Sep 19, 2022
@harsha509
Copy link
Member

Congratulations on your first contribution to selenium docs @TDroogers 🎉 🎉 🎉 !

selenium-ci added a commit that referenced this pull request Sep 19, 2022
* Missing closing parentheses

* Other languages. f2c2a0e
@TDroogers TDroogers deleted the patch-1 branch September 19, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants