-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[js] Adding logger documentation #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think we should put this whole page in a tab rather than bullet points per language. What do you think? |
74306ff
to
7749ff8
Compare
This is formatted incorrectly. We changed how tabs need to display code with the latest Docsy update, needs to be And can we move & update the Thanks! |
Thank you for the help regarding formatting @titusfortner. I have pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I'm not clear on...
Also, can we get an example of what actual output looks like based on example code?
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
1099a53
to
ad66705
Compare
Can you elaborate this a little please @titusfortner? Do you want to show outputs for different languages in their respective tabs along with a working sample code? |
ad66705
to
5161a58
Compare
I meant like just a line showing actual output. Like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts to make it more language-agnostic. I can update the Ruby tab things after the next pass. Thanks!
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
5161a58
to
999e673
Compare
999e673
to
9cf75a0
Compare
Please have a look @titusfortner. Let me know if any changes are to be made. This PR only adds JS and ruby sections. For other bindings I'll make separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple minor tweaks.
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Outdated
Show resolved
Hide resolved
Changes pushed. |
Oh, and this probably should use markdown instead of html. https://www.selenium.dev/documentation/about/style/#using-markdown-in-a-tab need to use |
Ah! Thank you for that link. I was just wondering how to use MD instead of HTML and was all over the internet for the solution. Will push the changes soon. |
lol, yeah, it isn't obvious. I only know because I was paying attention to those specific changes when they were made (we didn't used to be able to do text in the tabs of any kind). |
I guess we need to have the files in the other languages in order to merge this. |
@diemol So should I push the docs for Java and Python in this same branch? (Also I haven't explored how things are done in C# and Kotlin hence that might take time) |
No, he means the other translated md files. Just copy paste what you have over and our amazing translators will do the rest. |
a966f54
to
0e8d25c
Compare
@titusfortner The @diemol I have added other language file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @TamsilAmani!
Description
Documentation on how to use Logging feature in JS binding. Formatting documentation for Ruby and JS.
Motivation and Context
SeleniumHQ/selenium#10944
Types of changes
Checklist