Skip to content

added content for the locator #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Mar 31, 2023

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Added content for the locator section for the element.

Motivation and Context

That section needed documentation

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 575d707
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6426bf3fea129f0008dcff0c
😎 Deploy Preview https://deploy-preview-1350--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pallavigitwork!

@diemol diemol merged commit 5a80353 into SeleniumHQ:trunk Apr 3, 2023
selenium-ci added a commit that referenced this pull request Apr 3, 2023
@pallavigitwork
Copy link
Member Author

thank you @harsha509 and @diemol

@pallavigitwork pallavigitwork deleted the locatorbranch branch September 27, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants