Skip to content

[py] fix line number #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

[py] fix line number #2081

merged 2 commits into from
Nov 27, 2024

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Nov 27, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Fixes line number of Python sample code to match with other languages

Motivation and Context

The current doc points to an incorrect code line which makes it confusing.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Corrected the line number in the Python code example across multiple language documentation files.
  • Ensured that the Python code example line number is consistent with other language examples.

Changes walkthrough 📝

Relevant files
Documentation
_index.en.md
Correct Python code example line number in English docs   

website_and_docs/content/documentation/webdriver/drivers/_index.en.md

  • Updated the line number in the Python code example.
  • Ensured consistency with other language examples.
  • +1/-1     
    _index.ja.md
    Correct Python code example line number in Japanese docs 

    website_and_docs/content/documentation/webdriver/drivers/_index.ja.md

  • Updated the line number in the Python code example.
  • Ensured consistency with other language examples.
  • +1/-1     
    _index.pt-br.md
    Correct Python code example line number in Portuguese docs

    website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md

  • Updated the line number in the Python code example.
  • Ensured consistency with other language examples.
  • +1/-1     
    _index.zh-cn.md
    Correct Python code example line number in Chinese docs   

    website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md

  • Updated the line number in the Python code example.
  • Ensured consistency with other language examples.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Nov 27, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 40f9d87

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Accuracy
    Verify that line 9 in the Python example file actually contains the relevant code being referenced

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 merged commit 588ba47 into SeleniumHQ:trunk Nov 27, 2024
    3 checks passed
    @Delta456 Delta456 deleted the driver_py branch December 3, 2024 18:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants