Skip to content

Activate GitHub workflow for online building of SCInsta IPA#28

Merged
SoCuul merged 21 commits into
SoCuul:devfrom
zeuikli:main
Sep 23, 2024
Merged

Activate GitHub workflow for online building of SCInsta IPA#28
SoCuul merged 21 commits into
SoCuul:devfrom
zeuikli:main

Conversation

@zeuikli

@zeuikli zeuikli commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Example : https://github.com/zeuikli/BHInsta/actions/runs/8732321318

Run workflow :
CleanShot 2024-04-18 at 12 10 19@2x

Please enter the iOS SDK version and the IPA URL, then wait for the completion of the IPA build.

Build Status : CleanShot 2024-04-18 at 12 23 38@2x

Confirm that the IPA file can be installed via eSign, but note that the image download feature is still not functioning properly.

@SoCuul SoCuul added enhancement New feature or improvement status: planned This is planned for a future release labels Apr 19, 2024
@SoCuul SoCuul self-assigned this Apr 19, 2024
@SoCuul SoCuul linked an issue Apr 19, 2024 that may be closed by this pull request

@SoCuul SoCuul left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just needs a few changes before it can be merged.

Comment thread .github/workflows/delete-workflow-runs.yml Outdated
Comment thread .github/workflows/buildapp.yml Outdated
Comment thread .github/workflows/buildapp.yml Outdated
Comment thread .github/workflows/buildapp.yml Outdated
Comment thread .github/workflows/buildapp.yml Outdated
Comment thread .github/workflows/buildapp.yml Outdated
@zeuikli

zeuikli commented Apr 20, 2024

Copy link
Copy Markdown
Contributor Author

After the review, you can merge your commit into the main branch.

@SoCuul SoCuul changed the title Activate GitHub workflow for online building of BHInsta IPA Activate GitHub workflow for online building of SCInsta IPA Apr 20, 2024
@SoCuul SoCuul self-requested a review April 20, 2024 07:05

@SoCuul SoCuul left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to look good. Before I merge it though, could you test out the workflow with the commits I've added to the PR.

If everything works as intended, I'll merge it as soon as I can!

@SoCuul SoCuul added this to the v0.4.0 milestone Apr 20, 2024
@zeuikli

zeuikli commented Apr 20, 2024

Copy link
Copy Markdown
Contributor Author

Update build.sh to fix the issue of IPA file not being found.

Added script commands to install pyzule.
#Install pyzule
bash -c "$(curl https://raw.githubusercontent.com/asdfzxcvbn/pyzule/main/install-pyzule.sh)"

Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta.

You can review my latest PR to verify these changes.

@SoCuul

SoCuul commented Apr 20, 2024

Copy link
Copy Markdown
Owner

Update build.sh to fix the issue of IPA file not being found.

Added script commands to install pyzule. #Install pyzule bash -c "$(curl https://raw.githubusercontent.com/asdfzxcvbn/pyzule/main/install-pyzule.sh)"

Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta.

You can review my latest PR to verify these changes.

It's super inefficient to install pyzule each time someone tries to build it, as they only need to install it once.

Could you just add it as another step in the buildapp workflow?

Also the build.sh functionality should be independant of the workflow. The workflow calls it from the repo folder, so it should work fine as-is.

@SoCuul SoCuul self-requested a review April 20, 2024 08:58
SoCuul
SoCuul previously requested changes Apr 20, 2024

@SoCuul SoCuul left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that needs to be changed is moving the pyzule stuff to a build step and reverting the changes in build.sh. The script should run fine if in the workflow step it cds into the folder, as all the paths in the shell script are relative to the current directory.

Comment thread build.sh Outdated
Comment thread build.sh Outdated
@zeuikli

zeuikli commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA.

@SoCuul

SoCuul commented Apr 22, 2024

Copy link
Copy Markdown
Owner

Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA.

I do not feel comfortable merging this into the main branch in its current state, as it would cause confusion for users who do not understand why the workflow fails on their end.

@SoCuul SoCuul removed this from the v0.4.0 milestone May 4, 2024
@zeuikli zeuikli closed this May 13, 2024
@SoCuul

SoCuul commented May 13, 2024

Copy link
Copy Markdown
Owner

@zeuikli If you're working on this, what do you think about adding a dropdown in the workflow settings to select between sideloaded ipa, rootless and rootful

@zeuikli

zeuikli commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

@SoCuul I have already updated the Github workflow and package dependencies to enable building IPA and deb files.
You can review my pull request, but since your settings are for local builds, I recommend not merging my PR into the main branch. Instead, you can create another branch for GitHub Actions use cases.

@zeuikli zeuikli reopened this Jun 20, 2024
@SoCuul

SoCuul commented Jun 25, 2024

Copy link
Copy Markdown
Owner

@SoCuul I have already updated the Github workflow and package dependencies to enable building IPA and deb files. You can review my pull request, but since your settings are for local builds, I recommend not merging my PR into the main branch. Instead, you can create another branch for GitHub Actions use cases.

Thank you so much for your work! I'll take a look at the PR when I can.

@ic3dlem0n

Copy link
Copy Markdown

W zeuiki now sideloading this won't more complicated than it already is

@SoCuul

SoCuul commented Aug 14, 2024

Copy link
Copy Markdown
Owner

I still plan on implementing this when I can find the time. Kinda burned out rn from working on this atm.

@SoCuul SoCuul changed the base branch from main to dev September 23, 2024 06:19
@SoCuul SoCuul dismissed their stale review September 23, 2024 06:22

I committed needed changes

@SoCuul SoCuul merged commit a2705e1 into SoCuul:dev Sep 23, 2024
@SoCuul

SoCuul commented Sep 23, 2024

Copy link
Copy Markdown
Owner

@zeuikli Thank you so much for your work on this! Incredibly appreciated by me 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement status: planned This is planned for a future release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Integrate with GitHub Actions

3 participants