[TF2] Windows crash on client connect

[nullprop]

srcds on windows is crashing immediately after client connect with message Unable to find return address. You are going to crash now!. First seen in sp commit 08635a3. Earlier versions seem to work fine.

[jordanbriere]

sp info?

[jordanbriere]

Seems like some offsets recently changed for that game which caused this issue. They should be up-to-date into 8e6f820. If you have auto_data_update enabled into your ../cfg/source-python/core_settings.ini file they should be pulled automatically when you restart your servers.

Thanks for the report!

[nullprop]

Still crashing with auto_data_update enabled. Here's the sp info:

--------------------------------------------------------
Checksum      : 251143848f1b8ad388fcdce3510f80c5
Date          : 2021-08-29 01:32:56.581183
OS            : Windows-10-10.0.19041
Game          : tf2
SP version    : 705
Github commit : 38e4fe48579f9445b878624a9439ce10e28aa7e6
Server plugins:
   00: Source.Python, (C) 2012-2020, Source.Python Team.
SP plugins:
--------------------------------------------------------

Here's the console output:

Server is hibernating
Connection to Steam servers successful.
   Public IP is ---.
Assigned anonymous gameserver Steam ID [A:1:2855433221:18334].
VAC secure mode is activated.
Client "Larry" connected (---:27006).
Server waking up from hibernation
Initializing core hook (run_command)...
Core hook (run_command) has been initialized.
Unable to find return address. You are going to crash now!
src\tier1\fileio.cpp (5036) : Assertion Failed: s_bExit
src\tier1\fileio.cpp (5036) : Assertion Failed: s_bExit
src\tier1\fileio.cpp (5038) : Assertion Failed: m_vecRegisteredWriters.Count() == 0
src\tier1\fileio.cpp (5038) : Assertion Failed: m_vecRegisteredWriters.Count() == 0

There is one more fileio assert after these ones but it's hard to catch since the srcds window closes itself and doesn't seem to get logged anywhere.

[jordanbriere]

It did fix it for me. With auto_data_update disabled and v705:

Client "L'In20Cible" connected (192.168.1.227:27006).
Server waking up from hibernation
Stringtable modelprecache compression: 24416 -> 11930 bytes: 0.13ms
Stringtable soundprecache compression: 92184 -> 40180 bytes: 0.47ms
Stringtable instancebaseline compression: 8299 -> 2501 bytes: 0.03ms
Stringtable ParticleEffectNames compression: 34256 -> 27318 bytes: 0.17ms
Stringtable Scenes compression: 47474 -> 21863 bytes: 0.20ms
Compressing fragments (109796 -> 108320 bytes): 0.06ms
Compressing fragments (16428 -> 13332 bytes): 0.07ms
Sending full update to Client L'In20Cible
Compressing fragments (10731 -> 8464 bytes): 0.04ms
Unable to find return address. You are going to crash now!
src\tier1\fileio.cpp (5036) : Assertion Failed: s_bExit
src\tier1\fileio.cpp (5036) : Assertion Failed: s_bExit
src\tier1\fileio.cpp (5038) : Assertion Failed: m_vecRegisteredWriters.Count() == 0
src\tier1\fileio.cpp (5038) : Assertion Failed: m_vecRegisteredWriters.Count() == 0

Same version with auto_data_update enabled:

Client "L'In20Cible" connected (192.168.1.227:27006).
Server waking up from hibernation
Stringtable modelprecache compression: 24416 -> 11930 bytes: 0.11ms
Stringtable soundprecache compression: 92184 -> 40180 bytes: 0.35ms
Stringtable instancebaseline compression: 8299 -> 2501 bytes: 0.04ms
Stringtable ParticleEffectNames compression: 34256 -> 27318 bytes: 0.17ms
Stringtable Scenes compression: 47474 -> 21863 bytes: 0.20ms
Compressing fragments (109796 -> 108320 bytes): 0.12ms
Compressing fragments (16428 -> 13332 bytes): 0.08ms
Sending full update to Client L'In20Cible
Compressing fragments (10731 -> 8464 bytes): 0.03ms
status
hostname: Team Fortress
version : 6623512/24 6623512 insecure (secure mode enabled, disconnected from Steam3)
udp/ip  : 192.168.56.1:27015
steamid : not logged in
account : not logged in  (No account specified)
map     : arena_byre at: 0 x, 0 y, 0 z
tags    : arena
players : 1 humans, 0 bots (24 max)
edicts  : 418 used of 2048 max
# userid name                uniqueid            connected ping loss state  adr
#      2 "L'In20Cible"       [U:1:19510774]      00:11       34    0 active 192.168.1.227:27006
Steamworks Stats: SERVER session id not available.

Can you please make sure the 3 modified files into 8e6f820 are properly being updated?

[nullprop]

For some reason I had the latest data zip file which stops auto_data_update from applying but the .ini files were out of date. Applying the files from 8e6f820 manually or just deleting the data.zip and restarting has fixed the issue. Thanks!