Add support for compiling against the sdk2013 branch #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce.Python into engine_sdk2013
There are some things in KeyValues.cpp that are not supported in c++11
Ayuto
requested changes
Dec 16, 2016
| @@ -277,7 +277,7 @@ Set(SOURCEPYTHON_KEYVALUES_MODULE_HEADERS | |||
|
|
|||
| Set(SOURCEPYTHON_KEYVALUES_MODULE_SOURCES | |||
| core/modules/keyvalues/keyvalues_wrap.cpp | |||
| ${SOURCESDK}/tier1/KeyValues.cpp | |||
| ${SOURCESDK}/public/tier1/KeyValues.h | |||
There was a problem hiding this comment.
That line could be removed completely as it gets included in shared.make.
| @@ -3,8 +3,11 @@ | |||
| # Purpose: This is the CMake file for the sdk2013 branch. | |||
| # ------------------------------------------------------------------ | |||
|
|
|||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} \ | |||
| -DINTERFACEVERSION_SERVERGAMEDLL=\"ServerGameDLL010\"") | |||
|
|
|||
There was a problem hiding this comment.
We should add a note that these two lines should be removed once the SDK has been updated:
https://github.com/alliedmodders/hl2sdk/blob/3957adff10fe20d38a62fa8c018340bf2618742b/public/eiface.h#L459-L467
| @@ -115,7 +115,7 @@ Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-invalid-offsetof -Wno-reorder") | |||
|
|
|||
| # Others | |||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mfpmath=sse -msse -m32 -fno-strict-aliasing") | |||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x -fno-threadsafe-statics -v -fvisibility=hidden") | |||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x -static-libgcc -static-libstdc++ -fno-threadsafe-statics -v -fvisibility=hidden") | |||
There was a problem hiding this comment.
static-libstdc++ doesn't compile well with CS:GO. Once you start the server SP will fail to load with undefined symbol: _zdlpv.
Ayuto
added a commit
that referenced
this pull request
Jun 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the compiling issues and seems to work after testing, the data files for sdk2013 aren't included however.