Plugin info update #176
Merged
Plugin info update #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation. Added some attributes to LoadedPlugin. Removed redundant hasattr() checks. Updated output of "sp plugin list".
…kwargs to add items to the dictionary.
…d logger. Removed unused description argument for SubCommandManager.
…dule level or in load
|
This all looks good and works well for my testing. I would agree with leaving the default as True. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
info.inifile that is stored in the plugin's main directory.get_plugin_instance()not being able to retrieve the instance during the load process of a plugin.get_plugin_info().plugins_directory.plugin_exists().get_plugin_directory().LoadedPlugin.__name__inget_plugin_instanceandget_plugin_info.I think this is ready to get merged. There is only one last question that might need to be discussed: currently, a public convar is created for every plugin that is loaded unless it's explicitly disabled by setting
public_convartoFalse. Do we want this behaviour or do we want to set the default value toFalse? I would keep the current default value (True).Please also test it on your own. If there is nothing else to do, I will create a wiki page to explain the new info style a little bit more.