Skip to content

Added entity instances caching. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 26, 2019
Merged

Added entity instances caching. #291

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bb03086
Added entity caching.
jordanbriere Nov 25, 2019
d8cef55
Made the cache lookup slightly faster.
jordanbriere Nov 25, 2019
285287f
Fixed a rare case where a base class initialisation would be skipped.
jordanbriere Nov 25, 2019
2aab39b
No need to wrap the classes that are not using the cache.
jordanbriere Nov 25, 2019
58fec31
Greatly improved the caching implementation.
jordanbriere Nov 25, 2019
d7cc213
Updated docstrings, etc.
jordanbriere Nov 25, 2019
d9f87dc
Moved the "cache" property to the Entity class so that it gets added …
jordanbriere Nov 25, 2019
52075fc
Moved the "cache" property back to the caching class so that it can b…
jordanbriere Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Made the cache lookup slightly faster.
  • Loading branch information
@jordanbriere
jordanbriere committed Nov 25, 2019
commit d8cef55653f52e9500faa18d39ec0c8d8c20b471
12 changes: 6 additions & 6 deletions addons/source-python/packages/source-python/entities/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ def __init__(self, index):

def __new__(self, index):
# Let's first lookup for a cached instance
caching = self in metaclass.cache
if caching:
cache = metaclass.cache[self]
if index in cache:
return cache[index]
cache = metaclass.cache.get(self, None)
if cache is not None:
obj = cache.get(index, None)
if obj is not None:
return obj

# Nothing in cache, let's create a new instance
obj = cls.__base__.__new__(self, index)
Expand All @@ -118,7 +118,7 @@ def __new__(self, index):
)

# Let's cache the new instance we just created
if caching:
if cache is not None:
cache[index] = obj

# We are done, let's return the instance
Expand Down