Skip to content

Added the ability to add callbacks to ConVar that will be called when ConVar is changed. #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added the ability to add callbacks to ConVar that will be called when ConVar is changed. #421

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ea5fab5
Added the ability to add callbacks to ConVar that will be called when…
CookStar Oct 2, 2021
759953f
Added ConVarChanged decorator class to cvars.
CookStar Oct 2, 2021
3672a3b
Fixed incorrect type of ConVarExt::GetMax.
CookStar Oct 3, 2021
04de099
Added callbacks clean-up.
CookStar Oct 3, 2021
3f07345
Changed ConVarExt::ClearCallback.
CookStar Oct 3, 2021
9a6330f
Merge branch 'master' into convar_changed
CookStar Oct 3, 2021
96145c7
Check if the callback can be called.
CookStar Oct 4, 2021
94e24ba
Changed to check if ConVar is a valid ConVar.
CookStar Oct 4, 2021
6fea4b5
Revert "Changed to check if ConVar is a valid ConVar."
CookStar Oct 4, 2021
080d8ca
Changed to raise an exception if ConCommand already exists when creat…
CookStar Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Changed to check if ConVar is a valid ConVar." 
This reverts commit 94e24ba.
  • Loading branch information
@CookStar
CookStar committed Oct 4, 2021
commit 6fea4b507e9f71e95e2e0837d7737f90a21874be
15 changes: 7 additions & 8 deletions addons/source-python/packages/source-python/cvars/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,15 @@ def __init__(self, *convars):

_convars = []
for convar in convars:
if isinstance(convar, str):
convar_name = convar
elif isinstance(convar, ConVar):
convar_name = convar.name
else:
if not isinstance(convar, (str, ConVar)):
raise ValueError('Given convar is not ConVar or ConVar name.')

convar = cvar.find_var(convar_name)
if convar is None:
raise ValueError(f'"{convar_name}" is not a valid ConVar.')
elif isinstance(convar, str):
convar_name = convar
convar = cvar.find_var(convar_name)
if convar is None:
raise ValueError(
f'"{convar_name}" is not a valid ConVar name.')

_convars.append(convar)

Expand Down