Skip to content

Removed unnecessary _BaseSound._unload_instance function. #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025
Merged

Removed unnecessary _BaseSound._unload_instance function. #496

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acc4f33
Removed unnecessary _BaseSound._unload_instance function
CookStar Sep 30, 2024
e5e54ae
Deleted WeakAutoUnload.
CookStar Sep 30, 2024
3ab632c
Changed _PrecacheBase also not to call self._downloads._unload_instan…
CookStar Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed unnecessary _BaseSound._unload_instance function
  • Loading branch information
@CookStar
CookStar authored Sep 30, 2024
commit acc4f339fcdc9147e0fc144dbaf53a298df9abee
5 changes: 0 additions & 5 deletions addons/source-python/packages/source-python/engines/sound.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,6 @@ def duration(self):
self._duration = value
return value

def _unload_instance(self):
"""Remove the sample from the downloads list."""
if self._downloads is not None:
self._downloads._unload_instance()


class Sound(_BaseSound):
"""Class used to interact with precached sounds.
Expand Down