Skip to content

Branch and bound #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 4, 2021
Merged

Conversation

threelittle87
Copy link
Contributor

Please include a summary of the change.
Please also include relevant motivation and context (if applicable).
Put 'x' in between square brackets to mark an item as complete.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
  • I have made corresponding changes to the DIRECTORY.md

@threelittle87 threelittle87 requested a review from siriak as a code owner July 26, 2021 08:21
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #230 (894c5ff) into master (03b9110) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   93.28%   93.43%   +0.14%     
==========================================
  Files         109      112       +3     
  Lines        4900     5009     +109     
==========================================
+ Hits         4571     4680     +109     
  Misses        329      329              
Impacted Files Coverage Δ
DataStructures/Stack/ArrayBasedStack.cs 97.50% <ø> (ø)
...lgorithms/Knapsack/BranchAndBoundKnapsackSolver.cs 100.00% <100.00%> (ø)
Algorithms/Knapsack/BranchAndBoundNode.cs 100.00% <100.00%> (ø)
Algorithms/Search/JumpSearcher.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a5393...894c5ff. Read the comment docs.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Very good overall and only need to polish a bit to make idiomatic C# :D

@siriak
Copy link
Member

siriak commented Aug 1, 2021

Could you give me permission to push to your repo? I'd like to add some tests and cleanups

@threelittle87
Copy link
Contributor Author

Could you give me permission to push to your repo? I'd like to add some tests and cleanups

Hi, I've invited you as a collaborator for the forked repo. Thank you so much for helping me in this contribution.

@hdkfc
Copy link

hdkfc commented Aug 4, 2021 via email

@threelittle87
Copy link
Contributor Author

threelittle87 commented Aug 4, 2021

@hdkfc Wait... What? I've sent a collab invitation to @siriak, so that he can push his changes to my repo, and I thank for his help. Did I accidentally send the invitation to you? (I am new to GItHub :(

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks once again for adding this algorithm, discrete optimization algorithms are probably my favorite piece of mathematics and I really enjoyed going over this one. Please review the changes I made and I'll merge if everything's ok.

@threelittle87
Copy link
Contributor Author

I am glad that you liked this algorithm. I think everything is ok. It's at least 10 times better than my old one. I've learnt a lot contributing this algorithm. Thanks again!

@siriak siriak merged commit f335df4 into TheAlgorithms:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants