-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Branch and bound #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch and bound #230
Conversation
…AndBoundKnapsackSolverTests.cs
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 93.28% 93.43% +0.14%
==========================================
Files 109 112 +3
Lines 4900 5009 +109
==========================================
+ Hits 4571 4680 +109
Misses 329 329
Continue to review full report at Codecov.
|
…e.cs to fix codacy issue.
… fix codecov iissue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Very good overall and only need to polish a bit to make idiomatic C# :D
Could you give me permission to push to your repo? I'd like to add some tests and cleanups |
Hi, I've invited you as a collaborator for the forked repo. Thank you so much for helping me in this contribution. |
i am sorry I am a fresh man. i just want to study some c# algorithms. I hope you can find another friend to help you.
…---Original---
From: "Wo Zi ***@***.***>
Date: Wed, Aug 4, 2021 11:56 AM
To: ***@***.***>;
Cc: ***@***.***>;
Subject: Re: [TheAlgorithms/C-Sharp] Branch and bound (#230)
Could you give me permission to push to your repo? I'd like to add some tests and cleanups
Hi, I've invited you as a collaborator for the forked repo. Thank you so much for helping me in this contribution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks once again for adding this algorithm, discrete optimization algorithms are probably my favorite piece of mathematics and I really enjoyed going over this one. Please review the changes I made and I'll merge if everything's ok.
I am glad that you liked this algorithm. I think everything is ok. It's at least 10 times better than my old one. I've learnt a lot contributing this algorithm. Thanks again! |
Please include a summary of the change.
Please also include relevant motivation and context (if applicable).
Put 'x' in between square brackets to mark an item as complete.