Skip to content

Sieve of Eratosthenes. #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Sieve of Eratosthenes. #377

merged 5 commits into from
Jan 30, 2023

Conversation

deljohnson1
Copy link
Contributor

  • [ X] I have performed a self-review of my code
  • [ X] My code follows the style guidelines of this project
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [ X] New and existing unit tests pass locally with my changes
  • [ X] Comments in areas I changed are up to date
  • [ X] I have added comments to hard-to-understand areas of my code
  • [ X] I have made corresponding changes to the README.md

@deljohnson1 deljohnson1 requested a review from siriak as a code owner January 29, 2023 00:31
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 95.75% // Head: 95.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c0da831) compared to base (59c7a7b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         218      218           
  Lines        8872     8887   +15     
=======================================
+ Hits         8495     8510   +15     
  Misses        377      377           
Impacted Files Coverage Δ
Algorithms/Other/SieveOfEratosthenes.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Codacy suggestions

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 8a5db71 into TheAlgorithms:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants