Skip to content

Add TBC Padding #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Add TBC Padding #413

merged 9 commits into from
Oct 9, 2023

Conversation

Kalkwst
Copy link
Contributor

@Kalkwst Kalkwst commented Oct 9, 2023

Add implementation of the Trailing-Bit-Complement padding. As always this class implements methods for adding, removing and validating the padding of a byte array.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@Kalkwst Kalkwst requested a review from siriak as a code owner October 9, 2023 11:34
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d65c7d1) 95.94% compared to head (77c83b9) 95.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.02%     
==========================================
  Files         224      225       +1     
  Lines        9338     9395      +57     
==========================================
+ Hits         8959     9016      +57     
  Misses        379      379              
Files Coverage Δ
Algorithms/Crypto/Paddings/TbcPadding.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit b6d7385 into TheAlgorithms:master Oct 9, 2023
@Kalkwst Kalkwst deleted the feature/TbcPadding branch July 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants