-
Notifications
You must be signed in to change notification settings - Fork 19.9k
Added new File WordBoggle.java in Java/Misc #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Largest range
Revert "Largest range"
Travis tests have failedHey @AzadN, TravisBuddy Request Identifier: 176d7240-1eb3-11eb-b069-4b84fe73ac29 |
I Don't know buddy what issue it is throwing to you. I have sent a PR containing exactly your files, and no issues with that PR. |
All my checks have passed successfully currently. You can check here itself. Thanks anyways for issuing the PR again for my help :) |
Congratulations, finally every thing fine. Hope it gets mergerd as soon as possible. |
@shellhub to issue separate PRs for each of the 8 remaining files, I'd have to issue separate PRs by creating separate branches on my local fork of the original Java repository and then issue PRs per branch. But on doing so, the prettier check fails since it won't be able to locate the branches with the same name on the original repository. So every time that one check will surely fail. Would it be an issue? Please do review my current separate PRs and help me with this doubt :) |
It is not necessary that you send PR only through the development or master branch. You can create unique branches for every PR. And a fun fact, usually PR is sent through a branch which gives direct idea about what is this PR about. You can also send through the master branch but unless the earlier PR is closed, the PR will be merged with previous one. Also pardon me but I am not familiar with trees. I am just a first year undergrad who hasn't joined the college yet. I would really try to review other than those, just I am a bit busy now days so hardly left with an hour or two, so it is hard for me to review. But I would surely try. |
@shellhub this is my 2nd pull request out of the original pull request #1990 with multiple files. Please review it and merge if found useful.
Edit: I actually wanted to issue a separate 3rd pull request for RangeInSortedArray.java but it was added as a change to this PR itself I don't know why so please go through that file also.
I tried merging PR from a different branch on my fork to master of this repo but it didn't pass all the checks hence reverted back to adding changes from my own fork's master to origin's master.
@Kush1101 could you too review this?
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}
.