ReverseWord & ReverseWordsTest #2022
Conversation
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ReveresWordsTest extends ReverseWords { |
There was a problem hiding this comment.
This is not proper way to write tests.
If you don't know how a test is to be written, please check DecimalToAnyBaseTestjava.
As you can see, it does not extend its source class. Instead it initializes its object with help of constructor.
Please do needful.
There was a problem hiding this comment.
I removed the import line and inheritance from ReverseWordsTest and initialized an object of ReverseWords in it.
| * @param s the string to convert | ||
| * @return the {@code String}, converted to a string with reveresed words. | ||
| */ | ||
| public static String isReverseWords(String s) { |
There was a problem hiding this comment.
Method name is kind of not in sync with what it does, i.e.
public static String isReverseWords(String s) {...} // Suggests that this will return boolean value.
public static String returnReverseWords(String s) {...} // Suggests that this will return reversed string value. NOTE : This is just an observation or suggestion.
There was a problem hiding this comment.
I renamed isReverseWords to returnReverseWords
|
I don't understand how you use the assertEquals. At the moment when I run the test java throw an exception because in your method return a string and then you compare with a boolean |
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.